mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 15:15:51 +03:00
[GH-ISSUE #279] Add proxy support for uploads #229
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#229
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @BobVul on GitHub (Feb 25, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/279
Originally assigned to: @NickeManarin on GitHub.
Some networks require proxies.
It would be useful to support some way to configure a HTTP(S) proxy, at a minimum. Even better if SOCKS4/5 proxies can be supported too, but those might require additional libraries.
@NickeManarin commented on GitHub (Mar 5, 2018):
I added the option to manually set a proxy or to get it from the default settings of the system.
Now the problem lies in testing this feature. I don't have a proxy enabled in here. Can you test it for me?
@BobVul commented on GitHub (Mar 6, 2018):
Thanks! Is there a binary or updated source available? The last commit on GitHub was 15 days ago.
At the moment I only have a SOCKS5 proxy, though I can get an HTTP bridge if necessary.
@NickeManarin commented on GitHub (Mar 6, 2018):
Thank you, I'll share the binary with you. Here's the file:
ScreenToGif.zip
I added support for HTTP proxy for now. I'll try Socks5 later.
Check if it's possible to download FFmpeg or Gifski (Options > Extras) and if it's possible to upload to Imgur/Gyfcat (you can use the anonymous upload).
Again, thank you for your help. :)
@BobVul commented on GitHub (Mar 6, 2018):
The manual proxy works well for both Imgur upload and Gifski download.
Unfortunately, the system proxy seems to not do anything (proxy specified via Internet Options, works with Firefox using system proxy).
@BobVul commented on GitHub (Mar 6, 2018):
As an example, I'd expect the request to appear in Fiddler when it's acting as the system proxy.
@NickeManarin commented on GitHub (Mar 7, 2018):
Thank you for testing :)
I fixed that issue with the system proxy not being used, it now returns the Windows settings.
ScreenToGif_Test.zip
@BobVul commented on GitHub (Mar 7, 2018):
Looks like it works. Thanks!
Only thing missing now is SOCKS but that's apparently significantly harder (in .NET) so maybe not worth the trouble.
@NickeManarin commented on GitHub (Mar 7, 2018):
Awesome!
Yes, not sure if it's that easy. :/
@NickeManarin commented on GitHub (Mar 26, 2018):
I'll leave SOCKS for later.