[GH-ISSUE #270] progress > text > percentage > wrong values #222

Closed
opened 2026-02-26 09:30:36 +03:00 by kerem · 5 comments
Owner

Originally created by @Shemesh on GitHub (Feb 14, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/270

Originally assigned to: @NickeManarin on GitHub.

hi,
go to: image > progress > text > percentage > remove the "show total value". and apply.

watch the values, they are wrong, displaying in THOUSANDS.

Originally created by @Shemesh on GitHub (Feb 14, 2018). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/270 Originally assigned to: @NickeManarin on GitHub. hi, go to: image > progress > text > percentage > remove the "show total value". and apply. watch the values, they are wrong, displaying in THOUSANDS.
kerem 2026-02-26 09:30:36 +03:00
Author
Owner

@NickeManarin commented on GitHub (Feb 14, 2018):

It's assuming the current installed culture of the OS. I need to fix this.

<!-- gh-comment-id:365763600 --> @NickeManarin commented on GitHub (Feb 14, 2018): It's assuming the current installed culture of the OS. I need to fix this.
Author
Owner

@NickeManarin commented on GitHub (Mar 22, 2018):

With v2.13, can you test if it's displaying the percentage as expected?

<!-- gh-comment-id:375489760 --> @NickeManarin commented on GitHub (Mar 22, 2018): With v2.13, can you test if it's displaying the percentage as expected?
Author
Owner

@Shemesh commented on GitHub (Mar 23, 2018):

sorry, v2.13, problems remain.
see attached animated gif:
top-left is: percentage > remove the "show total value"
bottom-right is: custom > $p%

plus - ux wise - when showing percentage there is no need to show fractions, e.g. 32.4... 76.9..
it is too much information. showing integers is better.

s2g

<!-- gh-comment-id:375571921 --> @Shemesh commented on GitHub (Mar 23, 2018): sorry, v2.13, problems remain. see attached animated gif: top-left is: percentage > remove the "show total value" bottom-right is: custom > `$p%` plus - ux wise - when showing percentage there is no need to show fractions, e.g. 32.4... 76.9.. it is too much information. showing integers is better. ![s2g](https://user-images.githubusercontent.com/2488980/37817223-26b2ebd2-2e87-11e8-92bb-89edb3f671f8.gif)
Author
Owner

@ashleedawg commented on GitHub (May 6, 2018):

Hi @NickeManarin - just FYI, there's still the issue of the %progress being out by 100×.

However, I disagree with the suggestion that the value be truncated to zero decimal places, since the fraction is relevant if the project is >100 frames. Perhaps the number format could be if (frames>100) {"0.0%"} else {"0%"}? (The user could still use the custom format for a truncated value, or vice-versa.)


@Shemesh - In the meantime you can also display the progress percentage (without the total) like this:

  • Alt+K (or click Image Progress), and set:

    Setting Value
    Type Text
    Precision Custom
    Format $p%
  • Then, hit Enter to apply the change (or click Apply.)

  • Other custom formats can be viewed by hovering your mouse over the Format box.

In case you couldn't tell, I'm just learning (and practicing) GitHub-flavoured markdown... Forgive me! 🤓

<!-- gh-comment-id:386866701 --> @ashleedawg commented on GitHub (May 6, 2018): [<img src="https://user-images.githubusercontent.com/29980309/39671685-1491573c-50d2-11e8-8504-acb808985b0f.png" height=150>](https://user-images.githubusercontent.com/29980309/39671685-1491573c-50d2-11e8-8504-acb808985b0f.png) Hi @NickeManarin - just FYI, there's still the issue of the %progress being out by 100×. However, I disagree with the suggestion that the value be truncated to zero decimal places, since the fraction is relevant if the project is >100 frames. Perhaps the number format could be `if (frames>100) {"0.0%"} else {"0%"}`? (The user could still use the custom format for a truncated value, or vice-versa.) --- @Shemesh - In the meantime you can also display the progress percentage (without the total) like this: - [x] **<kbd>Alt</kbd>+<kbd>K</kbd>** (or click `Image `→ `Progress`), and set: Setting|Value -------|----- Type|`Text` Precision|`Custom` Format|`$p%` - [x] Then, hit <kbd>Enter</kbd> to apply the change (or click `Apply`.) - [ ] Other custom formats can be viewed by hovering your mouse over the _Format_ box. <sub><sub>In case you couldn't tell, I'm just learning (and practicing) [**GitHub-flavoured markdown**](https://guides.github.com/features/mastering-markdown/#syntax)... Forgive me! :nerd_face: </sub></sub>
Author
Owner

@NickeManarin commented on GitHub (May 6, 2018):

Ok, I was able to fix this.

<!-- gh-comment-id:386913371 --> @NickeManarin commented on GitHub (May 6, 2018): Ok, I was able to fix this.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#222
No description provided.