mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[GH-ISSUE #362] Bug when cancelling the codec selection window when using the system encoder #1667
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#1667
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @vletoux on GitHub (Jul 28, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/362
Originally assigned to: @NickeManarin on GitHub.
On a brand new install of Windows 7 with latest patches and the latest version of ScreenToGif, I tried to save a video.
I selected the « system » encoder and it showed a Window to select a codec.
Without any good codec, I pressed cancel and the application crashed immediately.
I see the crash occurs in the Dispose method of the AviWriter class.
This is a non blocking bug but happens quite surprisingly and without recovery possibility.
=> should the exception management being handled at a higher level to avoid an application crash (and the lost of its data) ?
@NickeManarin commented on GitHub (Jul 28, 2018):
Thanks, I was able to fix this bug and it will be available with the next release (v2.14).
It will still appear as an error after cancelling the encoding, but it wont crash the app.
@NickeManarin commented on GitHub (Jul 29, 2018):
Btw, if the app closed for you, you can recover your project by clicking on the Recent Projects button.