[GH-ISSUE #287] Import a GifFile without normal file ending #1604

Closed
opened 2026-03-01 18:46:50 +03:00 by kerem · 3 comments
Owner

Originally created by @EndlessMISAKA on GitHub (Mar 13, 2018).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/287

Originally assigned to: @NickeManarin on GitHub.

When a GifFile is not end with a GIF Trailer, that the Program will getting into a no-end loading.
Since we used the same Decoder, so I used the bad giffile to tested, and found this bug.
In my program this bug will throw a exception, so I changed the code to ignore the exception.

Maybe you will has a question that why should I need to fixed this bug?
Because this bad giffile can open by Windows Photo like a normal giffile.

bad

Best Wishes to you.This is a wonderful program.
(Sorry,I don't good at English.)

Originally created by @EndlessMISAKA on GitHub (Mar 13, 2018). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/287 Originally assigned to: @NickeManarin on GitHub. When a GifFile is not end with a GIF Trailer, that the Program will getting into a no-end loading. Since we used the same Decoder, so I used the bad giffile to tested, and found this bug. In my program this bug will throw a exception, so I changed the code to ignore the exception. Maybe you will has a question that why should I need to fixed this bug? Because this bad giffile can open by Windows Photo like a normal giffile. ![bad](https://user-images.githubusercontent.com/25360394/37323444-d8bffdcc-26be-11e8-90d8-460cbb3296a3.gif) Best Wishes to you.This is a wonderful program. (Sorry,I don't good at English.)
kerem 2026-03-01 18:46:50 +03:00
Author
Owner

@vatterspun commented on GitHub (Mar 16, 2018):

I'm not sure I understand what you're having issues with.

(Sorry,I don't good at English.)

Could you describe what you saw? Could you then describe what went wrong? What were you expecting to see?

<!-- gh-comment-id:373567120 --> @vatterspun commented on GitHub (Mar 16, 2018): I'm not sure I understand what you're having issues with. > (Sorry,I don't good at English.) Could you describe what you saw? Could you then describe what went wrong? What were you expecting to see?
Author
Owner

@NickeManarin commented on GitHub (Mar 16, 2018):

@vatterspun The app stays in an infinite loading process when a corrupted gif file is imported. So, @EndlessMISAKA wants the app to be able to load all possible frames, without staying in an infinite loading.

<!-- gh-comment-id:373579081 --> @NickeManarin commented on GitHub (Mar 16, 2018): @vatterspun The app stays in an infinite loading process when a corrupted gif file is imported. So, @EndlessMISAKA wants the app to be able to load all possible frames, without staying in an infinite loading.
Author
Owner

@NickeManarin commented on GitHub (Mar 16, 2018):

Done. With v2.13, it will load all frames until it can read anymore.

image

<!-- gh-comment-id:373580994 --> @NickeManarin commented on GitHub (Mar 16, 2018): Done. With v2.13, it will load all frames until it can read anymore. ![image](https://user-images.githubusercontent.com/14798947/37499966-80019c34-28a5-11e8-855f-293ddfd55172.png)
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#1604
No description provided.