mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[GH-ISSUE #79] [Bug] KeypressOSD bugs #1440
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#1440
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Kristinita on GitHub (Feb 6, 2017).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/79
1. Summary
Sometimes I get bad quality GIFs use ScreenToGIF if I record GIF with KeypressOSD AutoHotkey script.
2. Expected behavior
Good GIF quality.
3. Actual behavior
4. Steps to reproduce
I record and edit my GIF → I save my GIFs in different encoders → I get actual behavior.
5. Environment
Operating system and version:
Windows 10 Enterprise LTSB 64-bit EN
ScreenToGIF:
2.4.0.170115
KeypressOSD:
2.10
Thanks.
@NickeManarin commented on GitHub (Feb 6, 2017):
The gif (from the ScreenToGif encoder) plays nicely on the link that you shared.
The gif (from the Legacy encoder) fails to render because the color being changed is close to the default dummy color (a color that will be represented as transparent), lime green.
I downloaded the project so I can debug it. Thanks.
@NickeManarin commented on GitHub (Feb 6, 2017):
I was able to identify and fix this bug. It happened because the encoder was set to use a dummy color, but it could not find when the perfect rectangle was introduced in a frame with no other pixel modification.
When failing to find the dummy color in the color map, the index 0 was set as transparent. That killed the red color in the example project.
@Kristinita commented on GitHub (Feb 7, 2017):
@NickeManarin, http://i.imgur.com/wQwsoWR.gif image successfully open for me in Chrome and Opera, but don't open in Firefox 51.0.1 (64-bit).
The problem reproduced for me in Safe Mode and in Firefox without plugins and user settings.
Firefox bug?
Thanks.
@NickeManarin commented on GitHub (Feb 7, 2017):
@Kristinita Working alright with Edge.
@Kristinita commented on GitHub (Feb 8, 2017):
@NickeManarin , is it Firefox bug or ScreenToGIF encoder bug?
The problem reproduce for me in other file, which I get in ScreenToGIF encoder:
GIF not open in Firefox.
Thanks.
@NickeManarin commented on GitHub (Feb 8, 2017):
Looks like a Firefox bug. If you open that gif on Firefox, press F12 to open the developers tool, go to the Network tab, refresh the page to detect the
GETcommand.Hover the cursor on top of the thumbnail of the
GETentry, you can see that the gif plays nicely.@Kristinita commented on GitHub (Feb 10, 2017):
Bugzilla@Mozilla Bug 1338551.
Thanks.