mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 07:05:54 +03:00
[GH-ISSUE #19] Overwritten files don't decrease in size #1385
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#1385
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @duarteframos on GitHub (Sep 27, 2016).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/19
One thing I have noticed in the past and has continued happening for several versions now is that if a file is saved overwriting an existing GIF recorded in a previous session it's file size never really decreases even if the new recording is smaller than the original.
Say I record a capture and save it has gif (henceforth called Capture_A.gif) with a file size of 2.5Mb, then close ScreenToGif . I then proceed to open a new session and make a second recording which is considerably shorter than the previous one.
If I save it as Capture_B.gif it has 1.3Mb, but if I turn on the Overwrite option and save it over Capture_A.gif it will still saved with 2.5Mb file regardless of the actual size.
If I go back to the file browser and erase Capture_A.gif and save it again it will correctly present it's 1.3Mb file size.
Is this intended behavior or some sort of bug?
@NickeManarin commented on GitHub (Sep 27, 2016):
It was a silly bug and it's fixed.
During the creation of the gif file, I was opening the file and overwriting instead of creating a new one.
It had to do with a wrong flag during a FileStream call.
:)
@duarteframos commented on GitHub (Sep 27, 2016):
Wow that was quick, you must have beaten some record of shortest time between a bug report and a bug fix in the history of man kind! :)
Thanks for the fix!
@NickeManarin commented on GitHub (Sep 27, 2016):
It was a very silly bug. :D