[PR #1404] [MERGED] Fix #829, #226: Update UI font handling to use dynamic resources #1360

Closed
opened 2026-02-26 09:34:33 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/1404
Author: @fz0000
Created: 7/18/2025
Status: Merged
Merged: 7/20/2025
Merged by: @NickeManarin

Base: devHead: feature/fonts


📝 Commits (1)

  • 811786a Update UI font handling to use dynamic resources

📊 Changes

44 files changed (+123 additions, -80 deletions)

View changed files

📝 Other/Translator/App.xaml (+1 -1)
📝 Other/Translator/Dialog.xaml (+1 -1)
📝 Other/Translator/ExceptionDialog.xaml (+2 -2)
📝 Other/Translator/ExceptionViewer.xaml (+4 -4)
📝 Other/Translator/Themes/Generic.xaml (+1 -1)
📝 Other/Translator/TranslatorWindow.xaml (+3 -3)
📝 ScreenToGif.Util/Extensions/InlineExtensions.cs (+1 -1)
📝 ScreenToGif.Util/LocalizationHelper.cs (+40 -0)
📝 ScreenToGif.ViewModel/Tasks/KeyStrokesViewModel.cs (+1 -1)
📝 ScreenToGif.ViewModel/Tasks/ProgressViewModel.cs (+1 -1)
📝 ScreenToGif.ViewModel/UploadPresets/History/History.cs (+1 -1)
📝 ScreenToGif.ViewModel/UploadPresets/History/ImgurHistory.cs (+1 -1)
📝 ScreenToGif/App.xaml (+3 -0)
📝 ScreenToGif/Controls/SelectControl.cs (+4 -4)
📝 ScreenToGif/Controls/SelectControlOld.cs (+6 -6)
📝 ScreenToGif/Themes/Common.xaml (+1 -1)
📝 ScreenToGif/Themes/EncoderListViewItem.xaml (+2 -2)
📝 ScreenToGif/Themes/Generic.xaml (+3 -3)
📝 ScreenToGif/Windows/Board.xaml (+4 -4)
📝 ScreenToGif/Windows/Editor.xaml (+6 -6)

...and 24 more files

📄 Description

Try to Fix the font issue for #829, #226

Segoe UI works well for most languages, except CJK and some complex scripts (Thai, Tamil, etc.).

I've replaced it with the default Windows UI font for CJK languages. Segoe UI will be used as the default and fallback font.

We can add more languages if needed. e.g. add { "ta", ("Nirmala UI", "Nirmala UI Semilight", "Nirmala UI Bold") }, for Tamil(I'm not sure. Maybe we should confirm with the Tamil translators).

Some fonts don't have semilight/semibold, so I use light/bold instead.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/1404 **Author:** [@fz0000](https://github.com/fz0000) **Created:** 7/18/2025 **Status:** ✅ Merged **Merged:** 7/20/2025 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `dev` ← **Head:** `feature/fonts` --- ### 📝 Commits (1) - [`811786a`](https://github.com/NickeManarin/ScreenToGif/commit/811786afb80d111a2087b7a76cdcfd0ab0e44b1f) Update UI font handling to use dynamic resources ### 📊 Changes **44 files changed** (+123 additions, -80 deletions) <details> <summary>View changed files</summary> 📝 `Other/Translator/App.xaml` (+1 -1) 📝 `Other/Translator/Dialog.xaml` (+1 -1) 📝 `Other/Translator/ExceptionDialog.xaml` (+2 -2) 📝 `Other/Translator/ExceptionViewer.xaml` (+4 -4) 📝 `Other/Translator/Themes/Generic.xaml` (+1 -1) 📝 `Other/Translator/TranslatorWindow.xaml` (+3 -3) 📝 `ScreenToGif.Util/Extensions/InlineExtensions.cs` (+1 -1) 📝 `ScreenToGif.Util/LocalizationHelper.cs` (+40 -0) 📝 `ScreenToGif.ViewModel/Tasks/KeyStrokesViewModel.cs` (+1 -1) 📝 `ScreenToGif.ViewModel/Tasks/ProgressViewModel.cs` (+1 -1) 📝 `ScreenToGif.ViewModel/UploadPresets/History/History.cs` (+1 -1) 📝 `ScreenToGif.ViewModel/UploadPresets/History/ImgurHistory.cs` (+1 -1) 📝 `ScreenToGif/App.xaml` (+3 -0) 📝 `ScreenToGif/Controls/SelectControl.cs` (+4 -4) 📝 `ScreenToGif/Controls/SelectControlOld.cs` (+6 -6) 📝 `ScreenToGif/Themes/Common.xaml` (+1 -1) 📝 `ScreenToGif/Themes/EncoderListViewItem.xaml` (+2 -2) 📝 `ScreenToGif/Themes/Generic.xaml` (+3 -3) 📝 `ScreenToGif/Windows/Board.xaml` (+4 -4) 📝 `ScreenToGif/Windows/Editor.xaml` (+6 -6) _...and 24 more files_ </details> ### 📄 Description Try to Fix the font issue for #829, #226 Segoe UI works well for most languages, except CJK and some complex scripts (Thai, Tamil, etc.). I've replaced it with the default Windows UI font for CJK languages. Segoe UI will be used as the default and fallback font. We can add more languages if needed. e.g. add `{ "ta", ("Nirmala UI", "Nirmala UI Semilight", "Nirmala UI Bold") },` for Tamil(I'm not sure. Maybe we should confirm with the Tamil translators). Some fonts don't have semilight/semibold, so I use light/bold instead. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 09:34:33 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#1360
No description provided.