[PR #1205] [MERGED] Fix "Mouse Events" button tooltip #1331

New issue

Closed

opened 2026-02-26 09:34:27 +03:00 by kerem · 0 comments

kerem commented 2026-02-26 09:34:27 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/1205
Author: @matthew-e-brown
Created: 6/14/2023
Status: ✅ Merged
Merged: 6/23/2023
Merged by: @NickeManarin

Base: dev ← Head: localization-fix

---

📝 Commits (4)

• 47e2af3 Update StringResources.ru.xaml
• e866fd7 Replace all '.MouseClicks' with '.MouseEvents'
• 9c58525 Update EN 'S.Command.MouseEvents' tooltip text
• ee7dd3c Update FR 'S.Command.MouseEvents' tooltip text

📊 Changes

27 files changed (+46 additions, -46 deletions)

View changed files

📝 ScreenToGif/Resources/Localization/StringResources.ar.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.cs.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.da.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.de.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.el.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.en.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.es-AR.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.es.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.fi.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.fr.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.he.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.hu.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.it.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.ja.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.ko.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.nl.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.pl.xaml (+1 -1)
📝 ScreenToGif/Resources/Localization/StringResources.pt-PT.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.pt.xaml (+2 -2)
📝 ScreenToGif/Resources/Localization/StringResources.ru.xaml (+3 -3)

...and 7 more files

📄 Description

PR #1046 changed the "Mouse Clicks" panel/button to "Mouse Events" instead, since mouse-related events could now be visible without clicking; a sensible change. However, the PR missed a few references to *.MouseClicks in the code, resulting in the tooltip for the button not showing up correctly.

This PR switches all references to *.MouseClicks to their respective *.MouseEvents versions in all language .xaml files in /Resources/Localization. Additionally, it updates the values for the text itself from "Mouse clicks" to "Mouse events" within the tooltip for English and French (because those are the two languages that I know).

It may be a good idea to let those on the localization teams know that "Mouse clicks" should be changed to "Mouse events" for consistency. I also noticed several references in the other files to S.MouseClicks.Warning.None—this string no longer appears, since it's not really possible for a recording not to have any generic "mouse events" like it is for clicks. It can probably be removed from the language files. I don't think either of these last two points are particularly urgent, though.

This PR fixes #1200.

Screenshots

Before

After

---

Cheers,
-- Matt

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/1205 **Author:** [@matthew-e-brown](https://github.com/matthew-e-brown) **Created:** 6/14/2023 **Status:** ✅ Merged **Merged:** 6/23/2023 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `dev` ← **Head:** `localization-fix` --- ### 📝 Commits (4) - [`47e2af3`](https://github.com/NickeManarin/ScreenToGif/commit/47e2af3a4e8c860e2196a8e077e2d05d32c4e2d6) Update StringResources.ru.xaml - [`e866fd7`](https://github.com/NickeManarin/ScreenToGif/commit/e866fd7f40834fb65894c290cb367c2c09e5ed23) Replace all '*.MouseClicks' with '*.MouseEvents' - [`9c58525`](https://github.com/NickeManarin/ScreenToGif/commit/9c585254a067291966c1346902d2c72c42e64468) Update EN 'S.Command.MouseEvents' tooltip text - [`ee7dd3c`](https://github.com/NickeManarin/ScreenToGif/commit/ee7dd3cab433a2ec8d99dbaf3bf6acb802374b4f) Update FR 'S.Command.MouseEvents' tooltip text ### 📊 Changes **27 files changed** (+46 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Resources/Localization/StringResources.ar.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.cs.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.da.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.de.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.el.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.en.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.es-AR.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.es.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.fi.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.fr.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.he.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.hu.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.it.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.ja.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.ko.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.nl.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.pl.xaml` (+1 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.pt-PT.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.pt.xaml` (+2 -2) 📝 `ScreenToGif/Resources/Localization/StringResources.ru.xaml` (+3 -3) _...and 7 more files_ </details> ### 📄 Description PR #1046 changed the "Mouse Clicks" panel/button to "Mouse Events" instead, since mouse-related events could now be visible without clicking; a sensible change. However, the PR missed a few references to `*.MouseClicks` in the code, resulting in the tooltip for the button not showing up correctly. This PR switches all references to `*.MouseClicks` to their respective `*.MouseEvents` versions in all language `.xaml` files in `/Resources/Localization`. Additionally, it updates the values for the text itself from "Mouse clicks" to "Mouse events" within the tooltip for English and French (because those are the two languages that I know). It may be a good idea to let those on the localization teams know that "Mouse clicks" should be changed to "Mouse events" for consistency. I also noticed several references in the other files to `S.MouseClicks.Warning.None`&mdash;this string no longer appears, since it's not really possible for a recording not to have any generic "mouse events" like it is for clicks. It can probably be removed from the language files. I don't think either of these last two points are particularly urgent, though. This PR fixes #1200. ## Screenshots ### Before   ### After   --- Cheers, -- Matt --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-26 09:34:27 +03:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

dev

v2.40

2.43.1

2.43

2.42.1

2.42

2.41.5

2.41.4

2.41.3

2.41.2

2.41.1

2.41

2.40.1

2.40

2.39

2.38.1

2.38

2.37.2

2.37.1

2.37

2.36

2.35.4

2.35.3

2.35.2

2.35.1

2.35

2.34.1

2.34

2.33.1

2.33

2.32.1

2.32

2.31

2.30.1

2.30

2.29.1

2.29

2.28.2

2.28.1

2.28

2.27.3

2.27.2

2.27.1

2.27

2.26.1

2.26

2.25

2.24.2

2.24.1

2.24

2.23.2

2.23.1

2.23

2.22.1

2.22

2.21.2

2.21.1

2.21

2.20.4

2.20.3

2.20.2

2.20.1

2.20

2.19.3

2.19.2

2.19.1

2.19

2.18

2.17.1

2.17

2.16

2.15.2

2.15.1

2.15

2.14.1

2.14

2.13.3

2.13.2

2.13.1

2.13

2.12.1

2.12

2.11

2.10

2.9

2.8.1

2.8

2.7.3

2.7.2

2.7.1

2.7

2.6

2.5

2.4

2.3.2

2.3.1

2.3

2.2

2.1

Labels

Clear labels   

copy cats

  

duplicated

  

future feature

  

pull-request

Mirrored from GitHub Pull Request

  

⬜ Accepted

  

⬜ Completed

  

⬜ Help Wanted 💪

  

⬜ In Progress

  

⬜ Missing Details

  

⬜ Pending

  

⬜ Waiting For Answer ⏳

  

🆕 feature preview

  

🔷 Bug 🐛

  

🔷 Out Of Scope

  

🔷 Out Of Scope

  

🔷 Question

  

🔷Enhancement

  

🔷Enhancement

  

🔷Invalid / External

  

🔷Knowledge Base

  

🔷Won't Fix

  

🕑 High

  

🕑 High

  

🕑 High

  

🕕 Medium

  

🕙 Low

  

🕛 Critical

No labels

copy cats

duplicated

future feature

pull-request

⬜ Accepted

⬜ Completed

⬜ Help Wanted 💪

⬜ In Progress

⬜ Missing Details

⬜ Pending

⬜ Waiting For Answer ⏳

🆕 feature preview

🔷 Bug 🐛

🔷 Out Of Scope

🔷 Out Of Scope

🔷 Question

🔷Enhancement

🔷Enhancement

🔷Invalid / External

🔷Knowledge Base

🔷Won't Fix

🕑 High

🕑 High

🕑 High

🕕 Medium

🕙 Low

🕛 Critical

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1331

No description provided.