[PR #1087] [MERGED] Show hours if duration is greater than or equal to 60 minutes #1305

Closed
opened 2026-02-26 09:34:22 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/1087
Author: @reduckted
Created: 3/6/2022
Status: Merged
Merged: 3/20/2022
Merged by: @NickeManarin

Base: devHead: bugfix/1084


📝 Commits (1)

  • 0e09fc8 1084 - Show hours if duration is greater than or equal to 60 minutes

📊 Changes

2 files changed (+33 additions, -1 deletions)

View changed files

ScreenToGif.Util/Converters/TimeSpanToString.cs (+31 -0)
📝 ScreenToGif/Themes/Generic.xaml (+2 -1)

📄 Description

Fixes #1084.

The number of days in a TimeSpan cannot be optionally shown just by using a forma string, so I've created an IValueConverter to format the duration.

Seconds:
image

Minutes:
image

image

Hours:
image

image

Days:
image


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/1087 **Author:** [@reduckted](https://github.com/reduckted) **Created:** 3/6/2022 **Status:** ✅ Merged **Merged:** 3/20/2022 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `dev` ← **Head:** `bugfix/1084` --- ### 📝 Commits (1) - [`0e09fc8`](https://github.com/NickeManarin/ScreenToGif/commit/0e09fc88a977b4e9887ca9001e3bd6c2b4c9885a) 1084 - Show hours if duration is greater than or equal to 60 minutes ### 📊 Changes **2 files changed** (+33 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `ScreenToGif.Util/Converters/TimeSpanToString.cs` (+31 -0) 📝 `ScreenToGif/Themes/Generic.xaml` (+2 -1) </details> ### 📄 Description Fixes #1084. The number of days in a TimeSpan cannot be optionally shown just by using a forma string, so I've created an `IValueConverter` to format the duration. Seconds: ![image](https://user-images.githubusercontent.com/10321525/156905353-5d7dda1d-b720-4c56-8b46-ddf57a031884.png) Minutes: ![image](https://user-images.githubusercontent.com/10321525/156905349-8bdfc95d-2cb3-4e29-b25e-9793401c224d.png) ![image](https://user-images.githubusercontent.com/10321525/156905341-4f83b3ba-d66b-4f52-a319-8c53c42ff0a6.png) Hours: ![image](https://user-images.githubusercontent.com/10321525/156905335-675e4356-bf72-4a16-8df1-101e658ac8e2.png) ![image](https://user-images.githubusercontent.com/10321525/156905325-f76d88aa-6dca-4100-9f51-c3fc4f8fcaa8.png) Days: ![image](https://user-images.githubusercontent.com/10321525/156905318-73016ccb-425d-4af1-b9e0-335a1681a7fd.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 09:34:22 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#1305
No description provided.