mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[PR #1087] [MERGED] Show hours if duration is greater than or equal to 60 minutes #1305
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#1305
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NickeManarin/ScreenToGif/pull/1087
Author: @reduckted
Created: 3/6/2022
Status: ✅ Merged
Merged: 3/20/2022
Merged by: @NickeManarin
Base:
dev← Head:bugfix/1084📝 Commits (1)
0e09fc81084 - Show hours if duration is greater than or equal to 60 minutes📊 Changes
2 files changed (+33 additions, -1 deletions)
View changed files
➕
ScreenToGif.Util/Converters/TimeSpanToString.cs(+31 -0)📝
ScreenToGif/Themes/Generic.xaml(+2 -1)📄 Description
Fixes #1084.
The number of days in a TimeSpan cannot be optionally shown just by using a forma string, so I've created an
IValueConverterto format the duration.Seconds:

Minutes:

Hours:

Days:

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.