[PR #965] [CLOSED] gifski addition fixed #1276

New issue

Closed

opened 2026-02-26 09:34:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:34:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/965
Author: @soysaucemo
Created: 8/8/2021
Status: ❌ Closed

Base: master ← Head: master

📄 Description

#962

fixed the order of settings (according to gifski's code)
pub struct GifskiSettings {
pub width: u32,
pub height: u32,
pub quality: u8,
pub fast: bool,
pub repeat: i16,
}
Since version 1.4.0 had been pubulished, set it to be default.(dll files'length built by different persons can be different, I got 606720bytes by version 1.4.0 x64)
No need to set up lastTimestamp when addframe, it can be auto-calc.
refer to gifski.h

Presentation timestamp (PTS) is time in seconds, since start of the file, when this frame is to be displayed.
For a 20fps video it could be frame_number/20.0. First frame must have PTS=0.
Frames with duplicate or out-of-order PTS will be skipped.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/965 **Author:** [@soysaucemo](https://github.com/soysaucemo) **Created:** 8/8/2021 **Status:** ❌ Closed **Base:** `master` ← **Head:** `master` --- ### 📄 Description #962 1. fixed the order of settings (according to gifski's code) pub struct GifskiSettings { pub width: u32, pub height: u32, pub quality: u8, pub fast: bool, pub repeat: i16, } 2. Since version 1.4.0 had been pubulished, set it to be default.(dll files'length built by different persons can be different, I got 606720bytes by version 1.4.0 x64) 3. No need to set up lastTimestamp when addframe, it can be auto-calc. refer to gifski.h * Presentation timestamp (PTS) is time in seconds, since start of the file, when this frame is to be displayed. * For a 20fps video it could be `frame_number/20.0`. First frame must have PTS=0. * Frames with duplicate or out-of-order PTS will be skipped. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>