[PR #963] [MERGED] fix: Exception for x86 on Gifski #1274

New issue

Closed

opened 2026-02-26 09:34:15 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:34:15 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/963
Author: @SEWeiTung
Created: 8/6/2021
Status: ✅ Merged
Merged: 9/25/2021
Merged by: @NickeManarin

Base: bugfix/962-Disable-gifski-in-x86 ← Head: fixErrGitSki

📝 Commits (1)

ea0a41e f

📊 Changes

5 files changed (+41 additions, -20 deletions)

View changed files

📝 ScreenToGif/UserControls/ExportPanel.xaml.cs (+20 -5)
📝 ScreenToGif/Util/FunctionLoader.cs (+7 -5)
📝 ScreenToGif/Util/GifskiInterop.cs (+9 -9)
📝 ScreenToGif/Windows/Options.xaml.cs (+4 -0)
📝 ScreenToGif/Windows/Other/Preset.xaml.cs (+1 -1)

📄 Description

Ref: https://github.com/NickeManarin/ScreenToGif/issues/962, with some codes formation.

After fix, disable download gifski and disable choices of gifski for x86:

For more: https://github.com/ImageOptim/gifski/issues/189

Remove exclipit conversion from Delegate to a generic type by using "where".

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/963 **Author:** [@SEWeiTung](https://github.com/SEWeiTung) **Created:** 8/6/2021 **Status:** ✅ Merged **Merged:** 9/25/2021 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `bugfix/962-Disable-gifski-in-x86` ← **Head:** `fixErrGitSki` --- ### 📝 Commits (1) - [`ea0a41e`](https://github.com/NickeManarin/ScreenToGif/commit/ea0a41ef760fcb5ae50588ee0ba2cf88fa5f5ddd) f ### 📊 Changes **5 files changed** (+41 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/UserControls/ExportPanel.xaml.cs` (+20 -5) 📝 `ScreenToGif/Util/FunctionLoader.cs` (+7 -5) 📝 `ScreenToGif/Util/GifskiInterop.cs` (+9 -9) 📝 `ScreenToGif/Windows/Options.xaml.cs` (+4 -0) 📝 `ScreenToGif/Windows/Other/Preset.xaml.cs` (+1 -1) </details> ### 📄 Description 1. Ref: https://github.com/NickeManarin/ScreenToGif/issues/962, with some codes formation. After fix, disable download gifski and disable choices of gifski for x86: ![choose](https://user-images.githubusercontent.com/52018749/128440850-07b5798a-9f8a-4b45-833c-043d995a67c7.png) ![download](https://user-images.githubusercontent.com/52018749/128440857-743fa629-f3a9-4a67-8498-fb9dd9e135c7.JPG) ![preset1](https://user-images.githubusercontent.com/52018749/128440859-9c9532fc-4390-4845-9868-96b37bc49c6d.png) ![preset2](https://user-images.githubusercontent.com/52018749/128440865-be16233a-c6bd-44bf-9035-6f61176be82d.png) For more: https://github.com/ImageOptim/gifski/issues/189 2. Remove exclipit conversion from Delegate to a generic type by using "where". --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>