[PR #951] [MERGED] fix: Use local symbol to mean "China" and "Taiwan" #1269

New issue

Closed

opened 2026-02-26 09:34:14 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:34:14 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/951
Author: @SEWeiTung
Created: 7/20/2021
Status: ✅ Merged
Merged: 9/25/2021
Merged by: @NickeManarin

Base: bugfix/951-Fix-country-flags ← Head: fixChineseLang

📝 Commits (1)

46b1559 fix: union the flags of "China" and "Taiwan"

📊 Changes

3 files changed (+8 additions, -17 deletions)

View changed files

📝 ScreenToGif/Resources/Flags.xaml (+7 -14)
📝 ScreenToGif/Windows/Options.xaml (+1 -1)
📝 ScreenToGif/Windows/Options.xaml.cs (+0 -2)

📄 Description

This quick fixture is for the flags between "China" and "Taiwan" for 2
reasons:

In China, "Taiwan" isn't the ONLY place to use traditional Chinese,
but HK and Macao as well. So it's ABSOLUTELY wrong to use "TaiWan" to
stand for "Traditional Chinese". For this senario, I suggest later if we
meet with HK, we can say "Traditional Chinese(HK)...", with the symbol
"zh-HK"...ect.
Taiwan isn't a country with its flag, it's very ambiguous.
When in UWP mode, Taiwan's flag is white, this is wrong, remove it to be in union by using local symbol.
Ref: RFC 4646, Tags for Identifying Languages

Before fix:

After fix:

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/951 **Author:** [@SEWeiTung](https://github.com/SEWeiTung) **Created:** 7/20/2021 **Status:** ✅ Merged **Merged:** 9/25/2021 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `bugfix/951-Fix-country-flags` ← **Head:** `fixChineseLang` --- ### 📝 Commits (1) - [`46b1559`](https://github.com/NickeManarin/ScreenToGif/commit/46b1559659c45b8e1501dc37c15f4797ff2c305d) fix: union the flags of "China" and "Taiwan" ### 📊 Changes **3 files changed** (+8 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Resources/Flags.xaml` (+7 -14) 📝 `ScreenToGif/Windows/Options.xaml` (+1 -1) 📝 `ScreenToGif/Windows/Options.xaml.cs` (+0 -2) </details> ### 📄 Description This quick fixture is for the flags between "China" and "Taiwan" for 2 reasons: 1. In China, "Taiwan" isn't the ONLY place to use traditional Chinese, but HK and Macao as well. So it's ABSOLUTELY wrong to use "TaiWan" to stand for "Traditional Chinese". For this senario, I suggest later if we meet with HK, we can say "Traditional Chinese(HK)...", with the symbol "zh-HK"...ect. 2. Taiwan isn't a country with its flag, it's very ambiguous. 3. When in UWP mode, Taiwan's flag is white, this is wrong, remove it to be in union by using local symbol. Ref: [RFC 4646, Tags for Identifying Languages](https://www.ietf.org/rfc/rfc4646.txt) --- Before fix: ![Before](https://user-images.githubusercontent.com/52018749/126287986-62f7922a-e93c-45a3-9625-6b046c1811bf.png) After fix: ![Fixed](https://user-images.githubusercontent.com/52018749/126288014-2b513236-ab3f-4ed8-a1da-9940ad181ec2.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 09:34:14 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1269

No description provided.

Rows
Columns