[PR #914] [MERGED] Fix missing extension in case location is not specified by the user. #1256

New issue

Closed

opened 2026-02-26 09:34:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:34:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/914
Author: @pawlos
Created: 6/9/2021
Status: ✅ Merged
Merged: 6/13/2021
Merged by: @NickeManarin

Base: bugfix/913-Missing-file-extension ← Head: issue-913

📝 Commits (1)

896bd9f Fix missing extension in case location is not specified by the user.

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 ScreenToGif/Util/EncodingManager.cs (+4 -4)

📄 Description

preset.Extension was not used when generating the file name when location was not picked by the user.

Also did some cleaning up as it looked like OutputFileName was set to a different guid than the guid used in file name in the FullPath.

Closes #913

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/914 **Author:** [@pawlos](https://github.com/pawlos) **Created:** 6/9/2021 **Status:** ✅ Merged **Merged:** 6/13/2021 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `bugfix/913-Missing-file-extension` ← **Head:** `issue-913` --- ### 📝 Commits (1) - [`896bd9f`](https://github.com/NickeManarin/ScreenToGif/commit/896bd9f55316d2c5d51162661a7fdf5d7a33d289) Fix missing extension in case location is not specified by the user. ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Util/EncodingManager.cs` (+4 -4) </details> ### 📄 Description preset.Extension was not used when generating the file name when location was not picked by the user. Also did some cleaning up as it looked like `OutputFileName` was set to a different guid than the guid used in file name in the `FullPath`. Closes #913 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>