[PR #912] [MERGED] Follow system theme for editor's checkboard. #1254

New issue

Closed

opened 2026-02-26 09:34:11 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:34:11 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/912
Author: @pawlos
Created: 6/5/2021
Status: ✅ Merged
Merged: 6/8/2021
Merged by: @NickeManarin

Base: feature/910-Editor-theme-to-follow-systems ← Head: issue-910

📝 Commits (1)

6dbaa50 Follow system theme for editor's checkboard.

📊 Changes

6 files changed (+67 additions, -31 deletions)

View changed files

📝 ScreenToGif/App.xaml.cs (+5 -0)
📝 ScreenToGif/Settings/UserSettings.cs (+6 -0)
📝 ScreenToGif/Util/Constants.cs (+17 -0)
📝 ScreenToGif/Util/ThemeHelper.cs (+1 -1)
📝 ScreenToGif/Windows/Options.xaml (+5 -0)
📝 ScreenToGif/Windows/Options.xaml.cs (+33 -30)

📄 Description

Added an option to set Editor's checkboard to follow system theme settings.

As the grid colors are set on specific colors in order to correctly keep the info about 'FollowSystem' option, and additional settings property was created to hold the value ('GridColorsFollowSystem`).

Additionally checkboard colors were extracted to existing Constants class in order to reuse them from certain parts of the code.

As a note, Options.xaml.cs class could be cleaned up a little bit in regards to those colors i.e. dead code in CheckBoardScheme but don't know whether I should do such changes in the same PR.

Closes #910 (though I didn't change the behavior about the title bar)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/912 **Author:** [@pawlos](https://github.com/pawlos) **Created:** 6/5/2021 **Status:** ✅ Merged **Merged:** 6/8/2021 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `feature/910-Editor-theme-to-follow-systems` ← **Head:** `issue-910` --- ### 📝 Commits (1) - [`6dbaa50`](https://github.com/NickeManarin/ScreenToGif/commit/6dbaa50923c583542347886502de4891debab402) Follow system theme for editor's checkboard. ### 📊 Changes **6 files changed** (+67 additions, -31 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/App.xaml.cs` (+5 -0) 📝 `ScreenToGif/Settings/UserSettings.cs` (+6 -0) 📝 `ScreenToGif/Util/Constants.cs` (+17 -0) 📝 `ScreenToGif/Util/ThemeHelper.cs` (+1 -1) 📝 `ScreenToGif/Windows/Options.xaml` (+5 -0) 📝 `ScreenToGif/Windows/Options.xaml.cs` (+33 -30) </details> ### 📄 Description Added an option to set Editor's checkboard to follow system theme settings. As the grid colors are set on specific colors in order to correctly keep the info about 'FollowSystem' option, and additional settings property was created to hold the value ('GridColorsFollowSystem`). Additionally checkboard colors were extracted to existing Constants class in order to reuse them from certain parts of the code. As a note, `Options.xaml.cs` class could be cleaned up a little bit in regards to those colors i.e. dead code in `CheckBoardScheme` but don't know whether I should do such changes in the same PR. Closes #910 (though I didn't change the behavior about the title bar) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 09:34:11 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1254

No description provided.

Rows
Columns