[PR #894] [MERGED] Removed _applyAction check from Playback CanExecute #1247

Closed
opened 2026-02-26 09:34:09 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/894
Author: @pawlos
Created: 5/12/2021
Status: Merged
Merged: 5/15/2021
Merged by: @NickeManarin

Base: bugfix/881-Playback-buttons-disabled-after-saveHead: issue-881


📝 Commits (4)

  • 92ade86 Merge branch 'dev'
  • 4841c73 Merge branch 'dev'
  • 4b73520 Merge branch 'dev'
  • 8f27313 Removed _applyAction check from Playback CanExecute

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 ScreenToGif/Windows/Editor.xaml.cs (+1 -1)

📄 Description

Removed _applyAction check from Playback_CanExecute as it seems not be needed for correct behavior of the app. Did the testing and didn't observe any unwanted behavior w/o this check.

Fix #881


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/894 **Author:** [@pawlos](https://github.com/pawlos) **Created:** 5/12/2021 **Status:** ✅ Merged **Merged:** 5/15/2021 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `bugfix/881-Playback-buttons-disabled-after-save` ← **Head:** `issue-881` --- ### 📝 Commits (4) - [`92ade86`](https://github.com/NickeManarin/ScreenToGif/commit/92ade869d8f31c24f57fd507dd24c5ea35a16777) Merge branch 'dev' - [`4841c73`](https://github.com/NickeManarin/ScreenToGif/commit/4841c730e5b9e558612ebe31bcb12778e70b8a4b) Merge branch 'dev' - [`4b73520`](https://github.com/NickeManarin/ScreenToGif/commit/4b73520722fdba8f02183524c97c9dd218c89f5c) Merge branch 'dev' - [`8f27313`](https://github.com/NickeManarin/ScreenToGif/commit/8f2731308e488f77f418c3d82ec8088bb30782c7) Removed _applyAction check from Playback CanExecute ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Windows/Editor.xaml.cs` (+1 -1) </details> ### 📄 Description Removed `_applyAction` check from `Playback_CanExecute` as it seems not be needed for correct behavior of the app. Did the testing and didn't observe any unwanted behavior w/o this check. Fix #881 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 09:34:09 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#1247
No description provided.