[PR #873] [MERGED] Fix selection of frames after Delete all next/prev command #1238

New issue

Closed

opened 2026-02-26 09:34:08 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:34:08 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/873
Author: @pawlos
Created: 5/2/2021
Status: ✅ Merged
Merged: 5/8/2021
Merged by: @NickeManarin

Base: bugfix/873-frame-selection-after-deleting-previous-next ← Head: fix-selection-after-remove

📝 Commits (1)

68619be Fix selection of frames after Delete all next/prev command

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 ScreenToGif/Windows/Editor.xaml.cs (+3 -3)

📄 Description

This small PR fixes the selection issue after Delete all next/previous commands. Before, for the "Delete all next" command range selection was cleared and only one frame was selected even if a range selection was before.

Currently, it will keep the original selection as it was before executing the command. Apparently whats only needed was a call to FrameListView.ScrollIntoView to move the list to the visible frame. The whole SelectNear was not really doing any good for the range selection.

Before (only one frame selected after command executes):

After (range selection kept):

Change in, "Delete All Previous" is done for consistency, it was working as expected even with SelectNear(0). I guess it was selecting already selected frame and not canceling range selection.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/873 **Author:** [@pawlos](https://github.com/pawlos) **Created:** 5/2/2021 **Status:** ✅ Merged **Merged:** 5/8/2021 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `bugfix/873-frame-selection-after-deleting-previous-next` ← **Head:** `fix-selection-after-remove` --- ### 📝 Commits (1) - [`68619be`](https://github.com/NickeManarin/ScreenToGif/commit/68619be9fabcf48ffe0fe845469967f725924c3f) Fix selection of frames after Delete all next/prev command ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Windows/Editor.xaml.cs` (+3 -3) </details> ### 📄 Description This small PR fixes the selection issue after Delete all next/previous commands. Before, for the "Delete all next" command range selection was cleared and only one frame was selected even if a range selection was before. Currently, it will keep the original selection as it was before executing the command. Apparently whats only needed was a call to `FrameListView.ScrollIntoView` to move the list to the visible frame. The whole `SelectNear` was not really doing any good for the range selection. Before (only one frame selected after command executes): ![s2g_before](https://user-images.githubusercontent.com/1296768/116811166-15670480-ab48-11eb-8b38-bbe422aa753d.gif) After (range selection kept): ![s2g_after](https://user-images.githubusercontent.com/1296768/116811169-1ac44f00-ab48-11eb-88c8-2e8d3ed8e0d7.gif) Change in, "Delete All Previous" is done for consistency, it was working as expected even with `SelectNear(0)`. I guess it was selecting already selected frame and not canceling range selection. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>