[PR #810] [MERGED] Slow play back fix (#134) #1218

New issue

Closed

opened 2026-02-26 09:34:03 +03:00 by kerem · 0 comments

kerem commented 2026-02-26 09:34:03 +03:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/810
Author: @mabakay
Created: 3/21/2021
Status: ✅ Merged
Merged: 4/11/2021
Merged by: @NickeManarin

Base: master ← Head: work/playback/slowPlaybackFix

---

📝 Commits (4)

• 5ce5f03 Slow play back fix (#134)
• 3867967 Slow play back fix (UI was accessed from non UI thread)
• 3221e7c Slow play back fix (drop frames setting added to playback options)
• 6593ece Slow play back fix (important code comments)

📊 Changes

7 files changed (+101 additions, -40 deletions)

View changed files

📝 ScreenToGif/Resources/Localization/StringResources.en.xaml (+4 -1)
📝 ScreenToGif/Resources/Localization/StringResources.pl.xaml (+4 -1)
📝 ScreenToGif/Resources/Settings.xaml (+1 -0)
📝 ScreenToGif/Util/UserSettings.cs (+7 -1)
📝 ScreenToGif/Windows/Editor.xaml (+7 -2)
📝 ScreenToGif/Windows/Editor.xaml.cs (+76 -35)
📝 ScreenToGif/Windows/Options.xaml (+2 -0)

📄 Description

Preview playback has few problems.

1. It uses System.Windows.Forms.Timer which has resolution about 16 ms and its multiples.
2. Processing time of bitmap and displaying it on UI was not taken into account.

First means that if frame delay is 20 ms it will be shown not earlier than after 32 ms. Second means that loading image, attaching it to UI control and refreshing whole interface is effectively pausing timer interval.

I have implemented two changes.

1. Got rid of System.Windows.Forms.Timer and replaced it with dedicated task executed by thread from domain thread pool when play command is invoked.
2. Added option to skip frames while during preview if behind schedule.

On example project with 96 frames in 720p and 10 ms of delay per every frame average time (for 10 passes) of play from first to last frame for original code was 5,2s. After changing timer to dedicated thread time dropped to 3,3s. After checking option to drop frames behind I have got 0,98s for 96 * 10 ms = 960 ms as target time.

I did add this option to editor settings

but now I see that there is probably more appropriate place here

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/810 **Author:** [@mabakay](https://github.com/mabakay) **Created:** 3/21/2021 **Status:** ✅ Merged **Merged:** 4/11/2021 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `work/playback/slowPlaybackFix` --- ### 📝 Commits (4) - [`5ce5f03`](https://github.com/NickeManarin/ScreenToGif/commit/5ce5f030e3d19a212b5a96cacf48623a11cc0db5) Slow play back fix (#134) - [`3867967`](https://github.com/NickeManarin/ScreenToGif/commit/38679674cee02a4660517ede9591ef7c66fb947e) Slow play back fix (UI was accessed from non UI thread) - [`3221e7c`](https://github.com/NickeManarin/ScreenToGif/commit/3221e7cca64e0ebdd7fc48e39f651978d1007a1a) Slow play back fix (drop frames setting added to playback options) - [`6593ece`](https://github.com/NickeManarin/ScreenToGif/commit/6593ece8e1cb34db4c44e15a2b371764b9f31fab) Slow play back fix (important code comments) ### 📊 Changes **7 files changed** (+101 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Resources/Localization/StringResources.en.xaml` (+4 -1) 📝 `ScreenToGif/Resources/Localization/StringResources.pl.xaml` (+4 -1) 📝 `ScreenToGif/Resources/Settings.xaml` (+1 -0) 📝 `ScreenToGif/Util/UserSettings.cs` (+7 -1) 📝 `ScreenToGif/Windows/Editor.xaml` (+7 -2) 📝 `ScreenToGif/Windows/Editor.xaml.cs` (+76 -35) 📝 `ScreenToGif/Windows/Options.xaml` (+2 -0) </details> ### 📄 Description Preview playback has few problems. 1. It uses System.Windows.Forms.Timer which has resolution about 16 ms and its multiples. 2. Processing time of bitmap and displaying it on UI was not taken into account. First means that if frame delay is 20 ms it will be shown not earlier than after 32 ms. Second means that loading image, attaching it to UI control and refreshing whole interface is effectively pausing timer interval. I have implemented two changes. 1. Got rid of System.Windows.Forms.Timer and replaced it with dedicated task executed by thread from domain thread pool when play command is invoked. 2. Added option to skip frames while during preview if behind schedule. On example project with 96 frames in 720p and 10 ms of delay per every frame average time (for 10 passes) of play from first to last frame for original code was **5,2s**. After changing timer to dedicated thread time dropped to **3,3s**. After checking option to drop frames behind I have got **0,98s** for 96 * 10 ms = 960 ms as target time. I did add this option to editor settings  but now I see that there is probably more appropriate place here  --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

kerem 2026-02-26 09:34:03 +03:00

• closed this issue
• added the
  pull-request
  label

kerem referenced this issue 2026-02-26 09:34:27 +03:00

[PR #1218] [MERGED] Up to date pt-PT localization #1332

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

master

dev

v2.40

2.43.1

2.43

2.42.1

2.42

2.41.5

2.41.4

2.41.3

2.41.2

2.41.1

2.41

2.40.1

2.40

2.39

2.38.1

2.38

2.37.2

2.37.1

2.37

2.36

2.35.4

2.35.3

2.35.2

2.35.1

2.35

2.34.1

2.34

2.33.1

2.33

2.32.1

2.32

2.31

2.30.1

2.30

2.29.1

2.29

2.28.2

2.28.1

2.28

2.27.3

2.27.2

2.27.1

2.27

2.26.1

2.26

2.25

2.24.2

2.24.1

2.24

2.23.2

2.23.1

2.23

2.22.1

2.22

2.21.2

2.21.1

2.21

2.20.4

2.20.3

2.20.2

2.20.1

2.20

2.19.3

2.19.2

2.19.1

2.19

2.18

2.17.1

2.17

2.16

2.15.2

2.15.1

2.15

2.14.1

2.14

2.13.3

2.13.2

2.13.1

2.13

2.12.1

2.12

2.11

2.10

2.9

2.8.1

2.8

2.7.3

2.7.2

2.7.1

2.7

2.6

2.5

2.4

2.3.2

2.3.1

2.3

2.2

2.1

Labels

Clear labels   

copy cats

  

duplicated

  

future feature

  

pull-request

Mirrored from GitHub Pull Request

  

⬜ Accepted

  

⬜ Completed

  

⬜ Help Wanted 💪

  

⬜ In Progress

  

⬜ Missing Details

  

⬜ Pending

  

⬜ Waiting For Answer ⏳

  

🆕 feature preview

  

🔷 Bug 🐛

  

🔷 Out Of Scope

  

🔷 Out Of Scope

  

🔷 Question

  

🔷Enhancement

  

🔷Enhancement

  

🔷Invalid / External

  

🔷Knowledge Base

  

🔷Won't Fix

  

🕑 High

  

🕑 High

  

🕑 High

  

🕕 Medium

  

🕙 Low

  

🕛 Critical

No labels

copy cats

duplicated

future feature

pull-request

⬜ Accepted

⬜ Completed

⬜ Help Wanted 💪

⬜ In Progress

⬜ Missing Details

⬜ Pending

⬜ Waiting For Answer ⏳

🆕 feature preview

🔷 Bug 🐛

🔷 Out Of Scope

🔷 Out Of Scope

🔷 Question

🔷Enhancement

🔷Enhancement

🔷Invalid / External

🔷Knowledge Base

🔷Won't Fix

🕑 High

🕑 High

🕑 High

🕕 Medium

🕙 Low

🕛 Critical

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1218

No description provided.