[PR #644] [MERGED] [RFC] suppress TargetNullValue on .mp4 extension #1168

New issue

Closed

opened 2026-02-26 09:33:53 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:33:53 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/644
Author: @bNobo
Created: 4/26/2020
Status: ✅ Merged
Merged: 4/29/2020
Merged by: @NickeManarin

Base: master ← Head: fix_issue_639

📝 Commits (1)

06a82be suppress TargetNullValue on .mp4 extension

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 ScreenToGif/Windows/Editor.xaml (+1 -1)

📄 Description

a null value in LatestVideoExtension user settings will make user settings saving crash and Settings.xaml emptied.

When TargetNullValue is set to ".mp4" value, LatestVideoExtension is set to "null" when the value ".mp4" is selected in the combo box. Then UserSettings.Save method will crash with a NullReferenceException.

I don't see the point of setting it to null so I think the simplier fix is to remove TargetNullValue on the binding.

Closes #639

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/644 **Author:** [@bNobo](https://github.com/bNobo) **Created:** 4/26/2020 **Status:** ✅ Merged **Merged:** 4/29/2020 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `fix_issue_639` --- ### 📝 Commits (1) - [`06a82be`](https://github.com/NickeManarin/ScreenToGif/commit/06a82be1aee49b57b47707aab8a413c6c397b65e) suppress TargetNullValue on .mp4 extension ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Windows/Editor.xaml` (+1 -1) </details> ### 📄 Description a null value in `LatestVideoExtension` user settings will make user settings saving crash and Settings.xaml emptied. When `TargetNullValue` is set to ".mp4" value, `LatestVideoExtension` is set to "null" when the value ".mp4" is selected in the combo box. Then `UserSettings.Save` method will crash with a `NullReferenceException`. I don't see the point of setting it to null so I think the simplier fix is to remove `TargetNullValue` on the binding. Closes #639 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 09:33:53 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1168

No description provided.

Rows
Columns