mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[PR #524] [CLOSED] Change Import Video method to use ffmpeg instead. #1136
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#1136
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NickeManarin/ScreenToGif/pull/524
Author: @manbokgo
Created: 10/2/2019
Status: ❌ Closed
Base:
master← Head:ffmpegVideoImport📝 Commits (3)
a37665bImport Video using ffmpeg. Selection Slider tweaked. Warning showed up when ffmpeg not present.ba1a773Import Video Scale. Calculate video duration in milliseconds via ffmepg.b60b2c0FFmpeg encoding shows Progress bar. Error handling on importing videos.📊 Changes
5 files changed (+220 additions, -120 deletions)
View changed files
📝
ScreenToGif/Controls/RangeSlider.cs(+22 -2)📝
ScreenToGif/Windows/Editor.xaml.cs(+54 -56)📝
ScreenToGif/Windows/Other/Encoder.xaml.cs(+35 -5)📝
ScreenToGif/Windows/Other/VideoSource.xaml(+3 -3)📝
ScreenToGif/Windows/Other/VideoSource.xaml.cs(+106 -54)📄 Description
#378
More precise capturing frames from videos.
Progress bar works fine with parsed ffmpeg output with -progress option. This trick could also be applied when you encode gif with ffmpeg.
I haven't done it yet.EDIT: DoneIn addition, due to laggy, unnecessary video jumping, Start/End time NumericUpDown no longer continuously change their value while dragging Selection Slider. Now only changes value when you finish drag on slider.
I just deleted whole old capturing methods, so ffmpeg is essential to import videos. Display warning status bar when trying to import vid and ffmpeg not set on program, commented out Editor.xaml.cs:4910 StatusList.Remove(~) for this.
I'm not good programmer. It will be very appreciated to improve these code.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.