[PR #358] [MERGED] Translations + fix #1114

New issue

Closed

opened 2026-02-26 09:33:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:33:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/358
Author: @spietras
Created: 7/18/2018
Status: ✅ Merged
Merged: 7/21/2018
Merged by: @NickeManarin

Base: master ← Head: master

📝 Commits (5)

28689d4 Merge pull request #9 from NickeManarin/master
551a53b Merge pull request #10 from NickeManarin/master
325e852 Updated polish translation. Credited myself
13e68d1 Fixed checking for opened windows
a6b4394 Merge pull request #11 from spietras/develop

📊 Changes

3 files changed (+131 additions, -56 deletions)

View changed files

📝 ScreenToGif/Resources/Localization/StringResources.pl.xaml (+128 -54)
📝 ScreenToGif/Util/Model/ApplicationViewModel.cs (+2 -1)
📝 ScreenToGif/Windows/Options.xaml (+1 -1)

📄 Description

Updated Polish translations and credited myself
Fixed counting opened windows when closing the app. There were some abstract windows (such as adorner) preventing closing the app. Now only loaded and non-empty windows are counted and the app closes successfully.

PS I keep making the same mistake over and over, updating fork on master and not squashing. Sorry. You can squash merge now if you want to.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/358 **Author:** [@spietras](https://github.com/spietras) **Created:** 7/18/2018 **Status:** ✅ Merged **Merged:** 7/21/2018 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`28689d4`](https://github.com/NickeManarin/ScreenToGif/commit/28689d4f0875d7c336a962da6e2aab60c0a43f44) Merge pull request #9 from NickeManarin/master - [`551a53b`](https://github.com/NickeManarin/ScreenToGif/commit/551a53b2da2496c3898db4343d6ddace500b230e) Merge pull request #10 from NickeManarin/master - [`325e852`](https://github.com/NickeManarin/ScreenToGif/commit/325e852723c575f3778ffdfdddcb3dd07ed37abb) Updated polish translation. Credited myself - [`13e68d1`](https://github.com/NickeManarin/ScreenToGif/commit/13e68d12affffce67b6d15237e3f13b9440e38c7) Fixed checking for opened windows - [`a6b4394`](https://github.com/NickeManarin/ScreenToGif/commit/a6b43948e4caef093146cd1b59349547c0f2fd43) Merge pull request #11 from spietras/develop ### 📊 Changes **3 files changed** (+131 additions, -56 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Resources/Localization/StringResources.pl.xaml` (+128 -54) 📝 `ScreenToGif/Util/Model/ApplicationViewModel.cs` (+2 -1) 📝 `ScreenToGif/Windows/Options.xaml` (+1 -1) </details> ### 📄 Description - Updated Polish translations and credited myself - Fixed counting opened windows when closing the app. There were some abstract windows (such as adorner) preventing closing the app. Now only loaded and non-empty windows are counted and the app closes successfully. PS I keep making the same mistake over and over, updating fork on master and not squashing. Sorry. You can squash merge now if you want to. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>