[PR #346] [MERGED] Stop countdown timer for new recorder UI #1112

New issue

Closed

opened 2026-02-26 09:33:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:33:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/346
Author: @EraserKing
Created: 6/25/2018
Status: ✅ Merged
Merged: 6/30/2018
Merged by: @NickeManarin

Base: master ← Head: fix-prestart-countdown

📝 Commits (1)

e978fb1 Stop countdown timer for new recorder UI

📊 Changes

1 file changed (+6 additions, -0 deletions)

View changed files

📝 ScreenToGif/Windows/Other/RecorderNew.xaml.cs (+6 -0)

📄 Description

When Pre-Start is in use and a countdown is running, pressing Stop button doesn't really stop the countdown, and the capture still starts after the countdown ends.

This commit should fix #344

Unfortunately I didn't have enough time to go over all modes, but at least for me, New Recorder UI works fine after this change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/346 **Author:** [@EraserKing](https://github.com/EraserKing) **Created:** 6/25/2018 **Status:** ✅ Merged **Merged:** 6/30/2018 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `fix-prestart-countdown` --- ### 📝 Commits (1) - [`e978fb1`](https://github.com/NickeManarin/ScreenToGif/commit/e978fb1772837716a66a16b128ce18e0bac8d195) Stop countdown timer for new recorder UI ### 📊 Changes **1 file changed** (+6 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Windows/Other/RecorderNew.xaml.cs` (+6 -0) </details> ### 📄 Description When Pre-Start is in use and a countdown is running, pressing Stop button doesn't really stop the countdown, and the capture still starts after the countdown ends. This commit should fix #344 Unfortunately I didn't have enough time to go over all modes, but at least for me, New Recorder UI works fine after this change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>