mirror of
https://github.com/NickeManarin/ScreenToGif.git
synced 2026-04-25 23:25:52 +03:00
[PR #345] [MERGED] Fix status control position on multi-monitor system #1110
Labels
No labels
copy cats
duplicated
future feature
pull-request
⬜ Accepted
⬜ Completed
⬜ Help Wanted 💪
⬜ In Progress
⬜ Missing Details
⬜ Pending
⬜ Waiting For Answer ⏳
🆕 feature preview
🔷 Bug 🐛
🔷 Out Of Scope
🔷 Out Of Scope
🔷 Question
🔷Enhancement
🔷Enhancement
🔷Invalid / External
🔷Knowledge Base
🔷Won't Fix
🕑 High
🕑 High
🕑 High
🕕 Medium
🕙 Low
🕛 Critical
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ScreenToGif#1110
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/NickeManarin/ScreenToGif/pull/345
Author: @EraserKing
Created: 6/25/2018
Status: ✅ Merged
Merged: 6/30/2018
Merged by: @NickeManarin
Base:
master← Head:fix-status-position📝 Commits (1)
d07da92Fix status control position on multi-monitor system📊 Changes
1 file changed (+10 additions, -1 deletions)
View changed files
📝
ScreenToGif/Controls/SelectControl.cs(+10 -1)📄 Description
This should fix #342 .
When multiple monitors are connected and the main monitor is not the most top / left one, the monitors whose position are even left / above the main monitor may have a negative coordinate as boundary.
However, the current cursor point is always starting from the most top / left corner as 0, 0, no negative value is obtained.
So, when you really draw something on the main monitor, the current cursor point may exceed the boundaries of all the monitors, and as a result, no status control toolbar is displayed.
This commit recalculates the current cursor point by taking the negative coordinate into consideration, to make sure it falls into the proper monitor.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.