[PR #345] [MERGED] Fix status control position on multi-monitor system #1110

Closed
opened 2026-02-26 09:33:41 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/345
Author: @EraserKing
Created: 6/25/2018
Status: Merged
Merged: 6/30/2018
Merged by: @NickeManarin

Base: masterHead: fix-status-position


📝 Commits (1)

  • d07da92 Fix status control position on multi-monitor system

📊 Changes

1 file changed (+10 additions, -1 deletions)

View changed files

📝 ScreenToGif/Controls/SelectControl.cs (+10 -1)

📄 Description

This should fix #342 .

When multiple monitors are connected and the main monitor is not the most top / left one, the monitors whose position are even left / above the main monitor may have a negative coordinate as boundary.
However, the current cursor point is always starting from the most top / left corner as 0, 0, no negative value is obtained.

So, when you really draw something on the main monitor, the current cursor point may exceed the boundaries of all the monitors, and as a result, no status control toolbar is displayed.

This commit recalculates the current cursor point by taking the negative coordinate into consideration, to make sure it falls into the proper monitor.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/345 **Author:** [@EraserKing](https://github.com/EraserKing) **Created:** 6/25/2018 **Status:** ✅ Merged **Merged:** 6/30/2018 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `fix-status-position` --- ### 📝 Commits (1) - [`d07da92`](https://github.com/NickeManarin/ScreenToGif/commit/d07da92a89b8ffdfcb255359f3dc7bacbf171b02) Fix status control position on multi-monitor system ### 📊 Changes **1 file changed** (+10 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Controls/SelectControl.cs` (+10 -1) </details> ### 📄 Description This should fix #342 . When multiple monitors are connected and the main monitor is not the most top / left one, the monitors whose position are even left / above the main monitor may have a negative coordinate as boundary. However, the current cursor point is always starting from the most top / left corner as 0, 0, no negative value is obtained. So, when you really draw something on the main monitor, the current cursor point may exceed the boundaries of all the monitors, and as a result, no status control toolbar is displayed. This commit recalculates the current cursor point by taking the negative coordinate into consideration, to make sure it falls into the proper monitor. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-26 09:33:41 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/ScreenToGif#1110
No description provided.