[PR #271] [MERGED] Small fixes for localization #1102

New issue

Closed

opened 2026-02-26 09:33:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:33:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/271
Author: @spietras
Created: 2/14/2018
Status: ✅ Merged
Merged: 2/16/2018
Merged by: @NickeManarin

Base: master ← Head: fixes

📝 Commits (7)

ced4423 More asynchronous code. Better error handling. Fixed logical mistakes. Cosmetic changes
51ec193 Removed redundant calls to Dispatcher
0530acc Optimization
44c94e4 Added status band to localization window. Asynchronous exporting.
c6df081 Disabling buttons for safety
c42e38b Rethrowing exceptions
c5dd5db Added comments. Renamed some variables

📊 Changes

4 files changed (+346 additions, -139 deletions)

View changed files

📝 Other/Translator/TranslatorWindow.xaml.cs (+162 -29)
📝 ScreenToGif/Util/LocalizationHelper.cs (+77 -69)
📝 ScreenToGif/Windows/Other/Localization.xaml (+2 -0)
📝 ScreenToGif/Windows/Other/Localization.xaml.cs (+105 -41)

📄 Description

Fixed mistakes from #269 and slightly changed existing code

Removed unnecessary calls to Dispatcher
Now language codes are stored in a variable (so we don't have to download them again in Localization window after clicking Add button)
In Translation window, the English language is downloaded at the start. It's necessary if someone wants to import resource first without refreshing
Added status band in Localization window
Made code more asynchronous when it was possible
Other minor cosmetic changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/271 **Author:** [@spietras](https://github.com/spietras) **Created:** 2/14/2018 **Status:** ✅ Merged **Merged:** 2/16/2018 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `fixes` --- ### 📝 Commits (7) - [`ced4423`](https://github.com/NickeManarin/ScreenToGif/commit/ced442382434fc4a08967705bfae5be5c2c0c89c) More asynchronous code. Better error handling. Fixed logical mistakes. Cosmetic changes - [`51ec193`](https://github.com/NickeManarin/ScreenToGif/commit/51ec193670a1366f0cee288b65ce256544f728d7) Removed redundant calls to Dispatcher - [`0530acc`](https://github.com/NickeManarin/ScreenToGif/commit/0530acc365573783584ff7be137bf2caa0fab98f) Optimization - [`44c94e4`](https://github.com/NickeManarin/ScreenToGif/commit/44c94e43a98fede0b378906404ddb37b2c81071e) Added status band to localization window. Asynchronous exporting. - [`c6df081`](https://github.com/NickeManarin/ScreenToGif/commit/c6df081fbf1bc2415305b0e192fd2ad0ab7fb4c2) Disabling buttons for safety - [`c42e38b`](https://github.com/NickeManarin/ScreenToGif/commit/c42e38bac081ec61f6717275e539a990bb061738) Rethrowing exceptions - [`c5dd5db`](https://github.com/NickeManarin/ScreenToGif/commit/c5dd5dbbd8da9482a28af6ece003a6a610d2608b) Added comments. Renamed some variables ### 📊 Changes **4 files changed** (+346 additions, -139 deletions) <details> <summary>View changed files</summary> 📝 `Other/Translator/TranslatorWindow.xaml.cs` (+162 -29) 📝 `ScreenToGif/Util/LocalizationHelper.cs` (+77 -69) 📝 `ScreenToGif/Windows/Other/Localization.xaml` (+2 -0) 📝 `ScreenToGif/Windows/Other/Localization.xaml.cs` (+105 -41) </details> ### 📄 Description Fixed mistakes from #269 and slightly changed existing code - Removed unnecessary calls to Dispatcher - Now language codes are stored in a variable (so we don't have to download them again in Localization window after clicking Add button) - In Translation window, the English language is downloaded at the start. It's necessary if someone wants to import resource first without refreshing - Added status band in Localization window - Made code more asynchronous when it was possible - Other minor cosmetic changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>