[PR #162] [MERGED] Improved localization #1074

New issue

Closed

opened 2026-02-26 09:33:34 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:33:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/162
Author: @spietras
Created: 7/3/2017
Status: ✅ Merged
Merged: 7/5/2017
Merged by: @NickeManarin

Base: master ← Head: improved-localization

📝 Commits (2)

9e098a2 Merge pull request #1 from NickeManarin/master
54f6b67 Improved Polish translarion and added missing localization in .xamls

📊 Changes

8 files changed (+435 additions, -333 deletions)

View changed files

📝 ScreenToGif/Resources/Localization/StringResources.en.xaml (+30 -0)
📝 ScreenToGif/Resources/Localization/StringResources.pl.xaml (+370 -300)
📝 ScreenToGif/Windows/Board.xaml (+4 -4)
📝 ScreenToGif/Windows/Editor.xaml (+2 -2)
📝 ScreenToGif/Windows/Options.xaml (+20 -20)
📝 ScreenToGif/Windows/Other/Feedback.xaml (+5 -3)
📝 ScreenToGif/Windows/Other/Localization.xaml (+3 -3)
📝 ScreenToGif/Windows/Other/Startup.xaml (+1 -1)

📄 Description

Firstly, I added all missing strings to polish resource file and improved existing ones.

Secondly, I replaced most of hard coded strings in .xamls with newly created ones from resources.

Everything is working as intended. There are only two "issues":

In settings, in Language tab, there is some text encouraging to translating the app. There are 3 sentences, but I had to slice each one of them into smaller fragments, because of hyperlinks in the middle.
In Localization window, there was info about the position of a resource file that is being used and one word was bold. Now after taking a string from resource file, it's not bold anymore. I couldn't find a way to do it nicely with different languages grammar and I didn't want to make a custom string parser. Too much work for that little effect.

So yeah, they are not really issues, unless you are a big perfectionist.

And BTW, there are still many things left to localize, especially tooltips on buttons in Editor window, but they are set and taken from code so I don't really know how to even approach translating them.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/162 **Author:** [@spietras](https://github.com/spietras) **Created:** 7/3/2017 **Status:** ✅ Merged **Merged:** 7/5/2017 **Merged by:** [@NickeManarin](https://github.com/NickeManarin) **Base:** `master` ← **Head:** `improved-localization` --- ### 📝 Commits (2) - [`9e098a2`](https://github.com/NickeManarin/ScreenToGif/commit/9e098a2c37968e407cc620b12a9f0dddc2b93848) Merge pull request #1 from NickeManarin/master - [`54f6b67`](https://github.com/NickeManarin/ScreenToGif/commit/54f6b67d623806a4a46034ddf7fd9f62cc5a1851) Improved Polish translarion and added missing localization in .xamls ### 📊 Changes **8 files changed** (+435 additions, -333 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Resources/Localization/StringResources.en.xaml` (+30 -0) 📝 `ScreenToGif/Resources/Localization/StringResources.pl.xaml` (+370 -300) 📝 `ScreenToGif/Windows/Board.xaml` (+4 -4) 📝 `ScreenToGif/Windows/Editor.xaml` (+2 -2) 📝 `ScreenToGif/Windows/Options.xaml` (+20 -20) 📝 `ScreenToGif/Windows/Other/Feedback.xaml` (+5 -3) 📝 `ScreenToGif/Windows/Other/Localization.xaml` (+3 -3) 📝 `ScreenToGif/Windows/Other/Startup.xaml` (+1 -1) </details> ### 📄 Description Firstly, I added all missing strings to polish resource file and improved existing ones. Secondly, I replaced most of hard coded strings in .xamls with newly created ones from resources. Everything is working as intended. There are only two "issues": 1. In settings, in Language tab, there is some text encouraging to translating the app. There are 3 sentences, but I had to slice each one of them into smaller fragments, because of hyperlinks in the middle. 2. In Localization window, there was info about the position of a resource file that is being used and one word was bold. Now after taking a string from resource file, it's not bold anymore. I couldn't find a way to do it nicely with different languages grammar and I didn't want to make a custom string parser. Too much work for that little effect. So yeah, they are not really issues, unless you are a big perfectionist. And BTW, there are still many things left to localize, especially tooltips on buttons in Editor window, but they are set and taken from code so I don't really know how to even approach translating them. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>