[PR #67] [CLOSED] Units for Total Duration #1058

New issue

Closed

opened 2026-02-26 09:33:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-26 09:33:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/NickeManarin/ScreenToGif/pull/67
Author: @phil-davis
Created: 1/20/2017
Status: ❌ Closed

Base: master ← Head: patch-1

📝 Commits (1)

2f24cae Units for Total Duration

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 ScreenToGif/Windows/Editor.xaml (+2 -2)

📄 Description

I'm not sure that a unit is needed here ("m" for "minutes"). It confused me a bit when I made a short screen recording and it said "Total Duration 0:00:12.345 m" and I thought "there is no way that recording is 12.345 minutes long".
Actually, because the first field is the hours (even though hard-coded to zero) there is some argument that the units are "hr". And the last part is seconds, so the unit could be "sec".
So I think best to not mention any unit of measure.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/NickeManarin/ScreenToGif/pull/67 **Author:** [@phil-davis](https://github.com/phil-davis) **Created:** 1/20/2017 **Status:** ❌ Closed **Base:** `master` ← **Head:** `patch-1` --- ### 📝 Commits (1) - [`2f24cae`](https://github.com/NickeManarin/ScreenToGif/commit/2f24caea7214e5d01a07cab43dda0c0f4e04bfdb) Units for Total Duration ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `ScreenToGif/Windows/Editor.xaml` (+2 -2) </details> ### 📄 Description I'm not sure that a unit is needed here ("m" for "minutes"). It confused me a bit when I made a short screen recording and it said "Total Duration 0:00:12.345 m" and I thought "there is no way that recording is 12.345 minutes long". Actually, because the first field is the hours (even though hard-coded to zero) there is some argument that the units are "hr". And the last part is seconds, so the unit could be "sec". So I think best to not mention any unit of measure. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-26 09:33:31 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-26 09:34:20 +03:00

[PR #1058] [MERGED] Update StringResources.de.xaml #1300

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1058

No description provided.

Rows
Columns