starred/ScreenToGif

Fork 0

mirror of https://github.com/NickeManarin/ScreenToGif.git synced 2026-04-26 07:35:54 +03:00

[GH-ISSUE #1391] [Bug] Crash after switching color theme #1024

New issue

Closed

opened 2026-02-26 09:33:19 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 09:33:19 +03:00

Owner

Originally created by @stef-19 on GitHub (Jun 9, 2025).
Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1391

Originally assigned to: @NickeManarin on GitHub.

Describe the bug
After switching to a different color theme the application crashes.

To Reproduce
Steps to reproduce the behavior:

Go to Options - Application
Select a different Color theme
Error message appears: "Error while selecting the app's theme"

Expected behavior
After selecting of a new color theme the application should switch to the new color theme.

Screenshots

Desktop (please complete the following information):

OS: Windows 10 22H2
Version 2.41.3

Additional context

► Title - 
	Error while selecting the app's theme.
♦ [Version] Date/Hour - 
	[2.41.3] 06/09/2025 03:14:00
▬ Message - 
	Object reference not set to an instance of an object.
○ Type - 
	System.NullReferenceException
▲ Source - 
	ScreenToGif
▼ TargetSite - 
	Void RefreshVisual()
♠ StackTrace - 
   at ScreenToGif.Controls.NotifyIcon.RefreshVisual() in R:\Source\ScreenToGif\ScreenToGif\Controls\NotifyIcon.cs:line 472
   at ScreenToGif.Util.ThemeHelper.RefreshNotificationIcon() in R:\Source\ScreenToGif\ScreenToGif\Util\ThemeHelper.cs:line 71
   at ScreenToGif.Util.ThemeHelper.SelectTheme(AppThemes theme) in R:\Source\ScreenToGif\ScreenToGif\Util\ThemeHelper.cs:line 44
   at ScreenToGif.Windows.Options.AppThemeComboBox_SelectionChanged(Object sender, SelectionChangedEventArgs e) in R:\Source\ScreenToGif\ScreenToGif\Windows\Options.xaml.cs:line 183

Originally created by @stef-19 on GitHub (Jun 9, 2025). Original GitHub issue: https://github.com/NickeManarin/ScreenToGif/issues/1391 Originally assigned to: @NickeManarin on GitHub. **Describe the bug** After switching to a different color theme the application crashes. **To Reproduce** Steps to reproduce the behavior: 1. Go to Options - Application 2. Select a different Color theme 3. Error message appears: "Error while selecting the app's theme" **Expected behavior** After selecting of a new color theme the application should switch to the new color theme. **Screenshots** ![Image](https://github.com/user-attachments/assets/5b1c0e73-3972-45db-944c-e0111fc9e77f) **Desktop (please complete the following information):** - OS: Windows 10 22H2 - Version 2.41.3 **Additional context** ``` ► Title - Error while selecting the app's theme. ♦ [Version] Date/Hour - [2.41.3] 06/09/2025 03:14:00 ▬ Message - Object reference not set to an instance of an object. ○ Type - System.NullReferenceException ▲ Source - ScreenToGif ▼ TargetSite - Void RefreshVisual() ♠ StackTrace - at ScreenToGif.Controls.NotifyIcon.RefreshVisual() in R:\Source\ScreenToGif\ScreenToGif\Controls\NotifyIcon.cs:line 472 at ScreenToGif.Util.ThemeHelper.RefreshNotificationIcon() in R:\Source\ScreenToGif\ScreenToGif\Util\ThemeHelper.cs:line 71 at ScreenToGif.Util.ThemeHelper.SelectTheme(AppThemes theme) in R:\Source\ScreenToGif\ScreenToGif\Util\ThemeHelper.cs:line 44 at ScreenToGif.Windows.Options.AppThemeComboBox_SelectionChanged(Object sender, SelectionChangedEventArgs e) in R:\Source\ScreenToGif\ScreenToGif\Windows\Options.xaml.cs:line 183 ```

kerem

2026-02-26 09:33:19 +03:00

closed this issue
added the
🔷 Bug 🐛

⬜ Completed
labels

kerem commented

2026-02-26 09:33:19 +03:00

Author

Owner

@NickeManarin commented on GitHub (Jun 9, 2025):

Thanks, the tooltip of the notification icon had not been created yet.

@NickeManarin commented on GitHub (Jun 9, 2025): Thanks, the tooltip of the notification icon had not been created yet.

kerem commented

2026-02-26 09:33:19 +03:00

Author

Owner

@fz0000 commented on GitHub (Jul 11, 2025):

github.com/NickeManarin/ScreenToGif@597220a95a/ScreenToGif/Controls/NotifyIcon.cs (L479-L486)
Hi @NickeManarin, This modification does not completely fix this issue.
It doesn’t crash when switching the color theme now, but the theme of the tray icon context menu is still incorrect unless I relaunch the app.

https://github.com/user-attachments/assets/cb8abbbe-a155-4005-8025-fce2b24c8c33

I found that this code was commented out in this commit. After uncommenting it, the NotifyToolTipElement is not null and the issue is resolved:
github.com/NickeManarin/ScreenToGif@dc91a5d90f/ScreenToGif/Controls/NotifyIcon.cs (L453)
Was this code commented out by mistake or because it had caused side effects before?

@fz0000 commented on GitHub (Jul 11, 2025): https://github.com/NickeManarin/ScreenToGif/blob/597220a95a568610a071588b4ae6e71c160ffc6e/ScreenToGif/Controls/NotifyIcon.cs#L479-L486 Hi @NickeManarin, This modification does not completely fix this issue. It doesn’t crash when switching the color theme now, but the theme of the tray icon context menu is still incorrect unless I relaunch the app. https://github.com/user-attachments/assets/cb8abbbe-a155-4005-8025-fce2b24c8c33 I found that this code was commented out in this commit. After uncommenting it, the `NotifyToolTipElement` is not null and the issue is resolved: https://github.com/NickeManarin/ScreenToGif/blob/dc91a5d90fe3a8a56f55b9e9473b8f652c76a615/ScreenToGif/Controls/NotifyIcon.cs#L453 Was this code commented out by mistake or because it had caused side effects before?

kerem referenced this issue

2026-02-26 09:34:18 +03:00

[PR #1024] [MERGED] Update StringResources.pl.xaml #1289

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/ScreenToGif#1024

No description provided.

Rows
Columns