[PR #446] [MERGED] 414 whitelist causes dup sync #481

New issue

Closed

opened 2026-02-28 01:24:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/446
Author: @eyedol
Created: 4/28/2016
Status: ✅ Merged
Merged: 2/13/2017
Merged by: @eyedol

Base: master ← Head: 414-whitelist-causes-dup-sync

📝 Commits (2)

af4af3d Send whitelisted number once
187731f Fine tune filtering logic so messages processed

📊 Changes

2 files changed (+118 additions, -46 deletions)

View changed files

📝 smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java (+13 -11)
📝 smssync/src/test/java/org/addhen/smssync/data/message/PostMessageTest.java (+105 -35)

📄 Description

Fixes for #414

This PR makes the following changes:

Add filter status checks before processing messages
Add test for the implementation

@alxndrsn If you get the chance, mind reviewing this? I was confusing myself on this one and would appreciate a second eye.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/446 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 4/28/2016 **Status:** ✅ Merged **Merged:** 2/13/2017 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `414-whitelist-causes-dup-sync` --- ### 📝 Commits (2) - [`af4af3d`](https://github.com/ushahidi/SMSSync/commit/af4af3db0f449165c2d518f587c53634822f279e) Send whitelisted number once - [`187731f`](https://github.com/ushahidi/SMSSync/commit/187731faee8dccef4845e0c6175564489abdf9c3) Fine tune filtering logic so messages processed ### 📊 Changes **2 files changed** (+118 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java` (+13 -11) 📝 `smssync/src/test/java/org/addhen/smssync/data/message/PostMessageTest.java` (+105 -35) </details> ### 📄 Description Fixes for #414 This `PR` makes the following changes: - Add filter status checks before processing messages - Add test for the implementation @alxndrsn If you get the chance, mind reviewing this? I was confusing myself on this one and would appreciate a second eye. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>