[PR #445] [MERGED] 410 remove unused fields #478

New issue

Closed

opened 2026-02-28 01:24:46 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:46 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/445
Author: @eyedol
Created: 4/27/2016
Status: ✅ Merged
Merged: 2/13/2017
Merged by: @eyedol

Base: master ← Head: 410-remove-unused-fields

📝 Commits (3)

cf666ec Remove sync count fields. Not needed anymore
5b96ae5 Remove ability to track sync state
f25aec7 Remove the SyncPendingMessages and it's related classes

📊 Changes

6 files changed (+47 additions, -602 deletions)

View changed files

📝 smssync/src/main/java/org/addhen/smssync/presentation/service/SmsReceiverService.java (+1 -4)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/SyncPendingMessagesService.java (+46 -89)
➖ smssync/src/main/java/org/addhen/smssync/presentation/task/SyncPendingMessagesTask.java (+0 -274)
➖ smssync/src/main/java/org/addhen/smssync/presentation/task/state/State.java (+0 -103)
➖ smssync/src/main/java/org/addhen/smssync/presentation/task/state/SyncPendingMessagesState.java (+0 -103)
➖ smssync/src/main/java/org/addhen/smssync/presentation/task/state/SyncState.java (+0 -29)

📄 Description

Fixes #410

This PR makes the following changes:

Remove SyncPendingMessageState class
Refactor SyncPendingMessagesService class to remove the call to SyncPendingMessageState classes

@alxndrsn have a minute to review this?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/445 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 4/27/2016 **Status:** ✅ Merged **Merged:** 2/13/2017 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `410-remove-unused-fields` --- ### 📝 Commits (3) - [`cf666ec`](https://github.com/ushahidi/SMSSync/commit/cf666ec686394d2185b04a73f0af081568082396) Remove sync count fields. Not needed anymore - [`5b96ae5`](https://github.com/ushahidi/SMSSync/commit/5b96ae5afb334db8488fa7ccb2ac464d43d5fa22) Remove ability to track sync state - [`f25aec7`](https://github.com/ushahidi/SMSSync/commit/f25aec7e174f11d66b962f1d061f9620052c5d0b) Remove the SyncPendingMessages and it's related classes ### 📊 Changes **6 files changed** (+47 additions, -602 deletions) <details> <summary>View changed files</summary> 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/SmsReceiverService.java` (+1 -4) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/SyncPendingMessagesService.java` (+46 -89) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/task/SyncPendingMessagesTask.java` (+0 -274) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/task/state/State.java` (+0 -103) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/task/state/SyncPendingMessagesState.java` (+0 -103) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/task/state/SyncState.java` (+0 -29) </details> ### 📄 Description Fixes #410 This `PR` makes the following changes: - Remove `SyncPendingMessageState` class - Refactor `SyncPendingMessagesService` class to remove the call to `SyncPendingMessageState` classes @alxndrsn have a minute to review this? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>