[PR #376] [MERGED] Don't close the `FileManager` on every write #455

New issue

Closed

opened 2026-02-28 01:24:41 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/376
Author: @alxndrsn
Created: 4/6/2016
Status: ✅ Merged
Merged: 4/22/2016
Merged by: @eyedol

Base: master ← Head: smssync_log-closing

📝 Commits (1)

f43d7d8 Don't close the FileManager on every write

📊 Changes

17 files changed (+51 additions, -51 deletions)

View changed files

📝 smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java (+5 -5)
📝 smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessage.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java (+14 -14)
📝 smssync/src/main/java/org/addhen/smssync/data/net/MessageHttpClient.java (+6 -6)
📝 smssync/src/main/java/org/addhen/smssync/presentation/presenter/AlertPresenter.java (+4 -4)
📝 smssync/src/main/java/org/addhen/smssync/presentation/presenter/DebugPresenter.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/receiver/BootReceiver.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/receiver/ConnectivityChangedReceiver.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/receiver/PowerStateChangedReceiver.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/receiver/SmsDeliveredReceiver.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/receiver/SmsSentReceiver.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/CheckTaskService.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/MessageResultsService.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/Scheduler.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/ServiceControl.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/SmsReceiverService.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/SyncPendingMessagesService.java (+4 -4)

📄 Description

Fix for #375

As the FileManager.append() method calls PrintWriter.println(), messages will be flushed to file on every log write. This may be inefficient.

I expect that the OS will close the file when the application shuts down.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/376 **Author:** [@alxndrsn](https://github.com/alxndrsn) **Created:** 4/6/2016 **Status:** ✅ Merged **Merged:** 4/22/2016 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `smssync_log-closing` --- ### 📝 Commits (1) - [`f43d7d8`](https://github.com/ushahidi/SMSSync/commit/f43d7d8f4331485df0ba5b89cbc43cdf89fe7d47) Don't close the `FileManager` on every write ### 📊 Changes **17 files changed** (+51 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java` (+5 -5) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessage.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java` (+14 -14) 📝 `smssync/src/main/java/org/addhen/smssync/data/net/MessageHttpClient.java` (+6 -6) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/presenter/AlertPresenter.java` (+4 -4) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/presenter/DebugPresenter.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/receiver/BootReceiver.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/receiver/ConnectivityChangedReceiver.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/receiver/PowerStateChangedReceiver.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/receiver/SmsDeliveredReceiver.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/receiver/SmsSentReceiver.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/CheckTaskService.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/MessageResultsService.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/Scheduler.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/ServiceControl.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/SmsReceiverService.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/SyncPendingMessagesService.java` (+4 -4) </details> ### 📄 Description Fix for #375 As the `FileManager.append()` method calls `PrintWriter.println()`, messages will be flushed to file on every log write. This may be inefficient. I expect that the OS will close the file when the application shuts down. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>