[PR #351] [MERGED] Fixes #341 - Fix many problems in v3 #447

New issue

Closed

opened 2026-02-28 01:24:39 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:39 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/351
Author: @eyedol
Created: 11/5/2015
Status: ✅ Merged
Merged: 11/6/2015
Merged by: @eyedol

Base: master ← Head: 341-fix-many-problems-in-v3

📝 Commits (7)

314643a Disable item press for web service list to make it possible to toggle a web service
b0bf0fb Convert log action bar icon to vector drawable
9a8b1e7 Make a POST request instead of a GET request to test integration URL
0b57fc2 Add extra condition to test if the payload has a success property
504b5f1 Anchor snackbar view to footer action button when updating an integration
ffb3204 Fix broken test
658be63 Downgrade swipe to delete

📊 Changes

19 files changed (+151 additions, -37 deletions)

View changed files

📝 smssync/build.gradle (+4 -1)
📝 smssync/src/internal/java/org/addhen/smssync/data/repository/InternalWebServiceDataRepository.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/data/net/AppHttpClient.java (+79 -8)
📝 smssync/src/main/java/org/addhen/smssync/data/repository/WebServiceDataRepository.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/domain/repository/WebServiceRepository.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/domain/usecase/webservice/TestWebServiceUsecase.java (+8 -7)
📝 smssync/src/main/java/org/addhen/smssync/presentation/presenter/webservice/AddWebServicePresenter.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/presenter/webservice/UpdateWebServicePresenter.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/AddWebServiceFragment.java (+9 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/ListWebServiceFragment.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/LogFragment.java (+0 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/UpdateWebServiceFragment.java (+14 -6)
➖ smssync/src/main/res/drawable-hdpi/delete.png (+0 -0)
➖ smssync/src/main/res/drawable-mdpi/delete.png (+0 -0)
➖ smssync/src/main/res/drawable-xhdpi/delete.png (+0 -0)
➕ smssync/src/main/res/drawable/ic_delete_white_24dp.xml (+24 -0)
📝 smssync/src/main/res/layout/fragment_add_web_service.xml (+1 -0)
📝 smssync/src/main/res/layout/list_web_service_item.xml (+1 -1)
📝 smssync/src/main/res/menu/log_menu.xml (+1 -1)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/351 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 11/5/2015 **Status:** ✅ Merged **Merged:** 11/6/2015 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `341-fix-many-problems-in-v3` --- ### 📝 Commits (7) - [`314643a`](https://github.com/ushahidi/SMSSync/commit/314643a1f8df82ad6e846337d4a65b37a2086d95) Disable item press for web service list to make it possible to toggle a web service - [`b0bf0fb`](https://github.com/ushahidi/SMSSync/commit/b0bf0fb9645ce84e3e5e83ce963d5118a5848d74) Convert log action bar icon to vector drawable - [`9a8b1e7`](https://github.com/ushahidi/SMSSync/commit/9a8b1e70c69add6eb23f665a5ace50fb861a264b) Make a POST request instead of a GET request to test integration URL - [`0b57fc2`](https://github.com/ushahidi/SMSSync/commit/0b57fc2195e554e79b976a3e3d514efa60c2087d) Add extra condition to test if the payload has a success property - [`504b5f1`](https://github.com/ushahidi/SMSSync/commit/504b5f17129bfba97f57f1466c22d39828e3bacd) Anchor snackbar view to footer action button when updating an integration - [`ffb3204`](https://github.com/ushahidi/SMSSync/commit/ffb32045ca3e4c05950b261da20c33419bb204ac) Fix broken test - [`658be63`](https://github.com/ushahidi/SMSSync/commit/658be63d4a147d6f1110f3c06522373914cdfdc9) Downgrade swipe to delete ### 📊 Changes **19 files changed** (+151 additions, -37 deletions) <details> <summary>View changed files</summary> 📝 `smssync/build.gradle` (+4 -1) 📝 `smssync/src/internal/java/org/addhen/smssync/data/repository/InternalWebServiceDataRepository.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/data/net/AppHttpClient.java` (+79 -8) 📝 `smssync/src/main/java/org/addhen/smssync/data/repository/WebServiceDataRepository.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/domain/repository/WebServiceRepository.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/domain/usecase/webservice/TestWebServiceUsecase.java` (+8 -7) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/presenter/webservice/AddWebServicePresenter.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/presenter/webservice/UpdateWebServicePresenter.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/AddWebServiceFragment.java` (+9 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/ListWebServiceFragment.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/LogFragment.java` (+0 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/UpdateWebServiceFragment.java` (+14 -6) ➖ `smssync/src/main/res/drawable-hdpi/delete.png` (+0 -0) ➖ `smssync/src/main/res/drawable-mdpi/delete.png` (+0 -0) ➖ `smssync/src/main/res/drawable-xhdpi/delete.png` (+0 -0) ➕ `smssync/src/main/res/drawable/ic_delete_white_24dp.xml` (+24 -0) 📝 `smssync/src/main/res/layout/fragment_add_web_service.xml` (+1 -0) 📝 `smssync/src/main/res/layout/list_web_service_item.xml` (+1 -1) 📝 `smssync/src/main/res/menu/log_menu.xml` (+1 -1) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>