[PR #346] [MERGED] Fix #339 - Fix a bug where selected time frequency is not saved #443

New issue

Closed

opened 2026-02-28 01:24:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/346
Author: @eyedol
Created: 11/4/2015
Status: ✅ Merged
Merged: 11/4/2015
Merged by: @eyedol

Base: master ← Head: 339-bug-fix-frequency-broken

📝 Commits (1)

39acc20 Fix #339 - Fix a bug where selected time frequency is not saved

📊 Changes

6 files changed (+61 additions, -50 deletions)

View changed files

📝 build.gradle (+1 -1)
📝 smssync/build.gradle (+1 -4)
📝 smssync/src/main/java/org/addhen/smssync/presentation/util/TimeFrequencyUtil.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/AutomationSettingsFragment.java (+4 -8)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/widget/TimePreference.java (+36 -26)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/widget/TimePreferenceFragmentDialog.java (+18 -10)

📄 Description

Add okay button to save the selected frequency
Remove debug log messages
Call dismiss on dialog to make sure it's dismissed when okayed
Also made the default frequency five minutes instead of 5 hours

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/346 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 11/4/2015 **Status:** ✅ Merged **Merged:** 11/4/2015 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `339-bug-fix-frequency-broken` --- ### 📝 Commits (1) - [`39acc20`](https://github.com/ushahidi/SMSSync/commit/39acc20718e14060e1e9edc845f5f35888716b11) Fix #339 - Fix a bug where selected time frequency is not saved ### 📊 Changes **6 files changed** (+61 additions, -50 deletions) <details> <summary>View changed files</summary> 📝 `build.gradle` (+1 -1) 📝 `smssync/build.gradle` (+1 -4) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/util/TimeFrequencyUtil.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/fragment/AutomationSettingsFragment.java` (+4 -8) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/widget/TimePreference.java` (+36 -26) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/widget/TimePreferenceFragmentDialog.java` (+18 -10) </details> ### 📄 Description - Add okay button to save the selected frequency - Remove debug log messages - Call dismiss on dialog to make sure it's dismissed when okayed - Also made the default frequency five minutes instead of 5 hours --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>