[PR #336] [MERGED] Fixes #333 - Fix major obvious issues to make way for a release #441

New issue

Closed

opened 2026-02-28 01:24:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/336
Author: @eyedol
Created: 10/3/2015
Status: ✅ Merged
Merged: 10/3/2015
Merged by: @eyedol

Base: master ← Head: 333-bug-fix-make-way-for-a-release

📝 Commits (1)

be78263 Fixes #333 - Fix major obvious issues to make way for a release

📊 Changes

54 files changed (+641 additions, -826 deletions)

View changed files

📝 build.gradle (+1 -1)
📝 sms-portals/build.gradle (+4 -0)
📝 smssync/build.gradle (+1 -1)
📝 smssync/src/internal/java/org/addhen/smssync/data/repository/InternalLogDataRepository.java (+2 -3)
📝 smssync/src/main/AndroidManifest.xml (+0 -41)
📝 smssync/src/main/java/org/addhen/smssync/data/database/BaseDatabaseHelper.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java (+3 -3)
📝 smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java (+11 -10)
📝 smssync/src/main/java/org/addhen/smssync/data/net/MessageHttpClient.java (+1 -2)
📝 smssync/src/main/java/org/addhen/smssync/data/repository/MessageDataRepository.java (+1 -2)
📝 smssync/src/main/java/org/addhen/smssync/domain/usecase/log/ListLogUsecase.java (+4 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/App.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/component/FilterComponent.java (+0 -3)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/component/IntegrationComponent.java (+0 -3)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/component/LogComponent.java (+0 -3)
📝 smssync/src/main/java/org/addhen/smssync/presentation/presenter/message/PublishMessagesPresenter.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/MessageResultsService.java (+3 -3)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/message/PublishMessageView.java (+2 -0)
➖ smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/FilterActivity.java (+0 -102)
➖ smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/IntegrationActivity.java (+0 -116)

...and 34 more files

📄 Description

Use a different pacakge name for internal build flavour
Fix app navigation so the right menu itme is selected when user navigates through the app
Fix so user is prompted to enable service when it's disabled and user attempts to publish a message.
Add lint option to not abort build when lint check fails for sms-portal builds
Fix search so you on filter only incoming messages
Only show search icon on incoming fragment
Implement deletion of published messages
Change checkboxes to switch comapt for enabling or disabling an action
Implement a custom divider decoration for recyclerview items
Show dividers and properly align log items
Fix few issues that may cause NPEs
Bump db version number

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/336 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 10/3/2015 **Status:** ✅ Merged **Merged:** 10/3/2015 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `333-bug-fix-make-way-for-a-release` --- ### 📝 Commits (1) - [`be78263`](https://github.com/ushahidi/SMSSync/commit/be78263e07b00fadf0bd431fa8d2726054abc374) Fixes #333 - Fix major obvious issues to make way for a release ### 📊 Changes **54 files changed** (+641 additions, -826 deletions) <details> <summary>View changed files</summary> 📝 `build.gradle` (+1 -1) 📝 `sms-portals/build.gradle` (+4 -0) 📝 `smssync/build.gradle` (+1 -1) 📝 `smssync/src/internal/java/org/addhen/smssync/data/repository/InternalLogDataRepository.java` (+2 -3) 📝 `smssync/src/main/AndroidManifest.xml` (+0 -41) 📝 `smssync/src/main/java/org/addhen/smssync/data/database/BaseDatabaseHelper.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java` (+3 -3) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java` (+11 -10) 📝 `smssync/src/main/java/org/addhen/smssync/data/net/MessageHttpClient.java` (+1 -2) 📝 `smssync/src/main/java/org/addhen/smssync/data/repository/MessageDataRepository.java` (+1 -2) 📝 `smssync/src/main/java/org/addhen/smssync/domain/usecase/log/ListLogUsecase.java` (+4 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/App.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/component/FilterComponent.java` (+0 -3) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/component/IntegrationComponent.java` (+0 -3) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/component/LogComponent.java` (+0 -3) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/presenter/message/PublishMessagesPresenter.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/MessageResultsService.java` (+3 -3) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/message/PublishMessageView.java` (+2 -0) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/FilterActivity.java` (+0 -102) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/IntegrationActivity.java` (+0 -116) _...and 34 more files_ </details> ### 📄 Description - Use a different pacakge name for internal build flavour - Fix app navigation so the right menu itme is selected when user navigates through the app - Fix so user is prompted to enable service when it's disabled and user attempts to publish a message. - Add lint option to not abort build when lint check fails for sms-portal builds - Fix search so you on filter only incoming messages - Only show search icon on incoming fragment - Implement deletion of published messages - Change checkboxes to switch comapt for enabling or disabling an action - Implement a custom divider decoration for recyclerview items - Show dividers and properly align log items - Fix few issues that may cause NPEs - Bump db version number --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>