[PR #335] [MERGED] 334 bug fix port old settings implementation #439

New issue

Closed

opened 2026-02-28 01:24:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/335
Author: @eyedol
Created: 9/30/2015
Status: ✅ Merged
Merged: 9/30/2015
Merged by: @eyedol

Base: master ← Head: 334-bug-fix-port-old-settings-implementation

📝 Commits (2)

047df09 Update android gradle plugin
04d50c1 Fix #334 - Port Old Settings Implement to Use PreferenceFragmentCompat

📊 Changes

42 files changed (+1226 additions, -610 deletions)

View changed files

📝 build.gradle (+1 -1)
📝 dependencies/dependencies.gradle (+17 -21)
📝 smssync/build.gradle (+0 -2)
📝 smssync/src/internal/java/org/addhen/smssync/presentation/di/component/AppComponent.java (+3 -0)
📝 smssync/src/main/AndroidManifest.xml (+0 -33)
📝 smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java (+11 -10)
📝 smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java (+1 -1)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/component/AppServiceComponent.java (+21 -5)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/component/SettingsComponent.java (+3 -0)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/module/AppModule.java (+10 -0)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/module/ServiceModule.java (+11 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/qualifier/ServiceScope.java (+7 -10)
📝 smssync/src/main/java/org/addhen/smssync/presentation/receiver/BootReceiver.java (+2 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/DeleteMessageService.java (+1 -0)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/MessageResultsService.java (+1 -1)
➖ smssync/src/main/java/org/addhen/smssync/presentation/service/ServiceRunner.java (+0 -206)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/SyncPendingMessagesService.java (+5 -2)
📝 smssync/src/main/java/org/addhen/smssync/presentation/service/UpdateMessageService.java (+1 -0)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/AutomationSettingsActivity.java (+2 -0)
➖ smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/GeneralSettingsActivity.java (+0 -167)

...and 22 more files

📄 Description

Upgrade Android plugin
Use PreferenceFragmentCompat from the Support Library
Replace CheckboxPreference with SwitchPreferenceCompat

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/335 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 9/30/2015 **Status:** ✅ Merged **Merged:** 9/30/2015 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `master` ← **Head:** `334-bug-fix-port-old-settings-implementation` --- ### 📝 Commits (2) - [`047df09`](https://github.com/ushahidi/SMSSync/commit/047df093eddcc188e8eb1c488b38714c1f9c6b1f) Update android gradle plugin - [`04d50c1`](https://github.com/ushahidi/SMSSync/commit/04d50c149db86bca96f2b77feff4aa13e3f64bbd) Fix #334 - Port Old Settings Implement to Use PreferenceFragmentCompat ### 📊 Changes **42 files changed** (+1226 additions, -610 deletions) <details> <summary>View changed files</summary> 📝 `build.gradle` (+1 -1) 📝 `dependencies/dependencies.gradle` (+17 -21) 📝 `smssync/build.gradle` (+0 -2) 📝 `smssync/src/internal/java/org/addhen/smssync/presentation/di/component/AppComponent.java` (+3 -0) 📝 `smssync/src/main/AndroidManifest.xml` (+0 -33) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java` (+11 -10) 📝 `smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java` (+1 -1) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/component/AppServiceComponent.java` (+21 -5) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/component/SettingsComponent.java` (+3 -0) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/module/AppModule.java` (+10 -0) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/module/ServiceModule.java` (+11 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/qualifier/ServiceScope.java` (+7 -10) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/receiver/BootReceiver.java` (+2 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/DeleteMessageService.java` (+1 -0) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/MessageResultsService.java` (+1 -1) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/service/ServiceRunner.java` (+0 -206) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/SyncPendingMessagesService.java` (+5 -2) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/service/UpdateMessageService.java` (+1 -0) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/AutomationSettingsActivity.java` (+2 -0) ➖ `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/GeneralSettingsActivity.java` (+0 -167) _...and 22 more files_ </details> ### 📄 Description - Upgrade Android plugin - Use PreferenceFragmentCompat from the Support Library - Replace CheckboxPreference with SwitchPreferenceCompat --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>