[PR #305] [MERGED] Fix #288 - Organize settings screen #427

Closed
opened 2026-02-28 01:24:34 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/305
Author: @eyedol
Created: 7/27/2015
Status: Merged
Merged: 7/27/2015
Merged by: @eyedol

Base: 3.0.0Head: 288-bug-fix


📝 Commits (1)

📊 Changes

62 files changed (+1981 additions, -143 deletions)

View changed files

📝 build.gradle (+1 -1)
📝 dependencies/dependencies.gradle (+16 -12)
📝 smssync/build.gradle (+6 -4)
📝 smssync/src/internal/java/org/addhen/smssync/presentation/di/component/AppComponent.java (+3 -1)
smssync/src/internal/res/xml/preference_headers_legacy.xml (+55 -0)
📝 smssync/src/main/AndroidManifest.xml (+59 -6)
📝 smssync/src/main/java/org/addhen/smssync/presentation/App.java (+1 -1)
smssync/src/main/java/org/addhen/smssync/presentation/Prefs.java (+155 -0)
smssync/src/main/java/org/addhen/smssync/presentation/di/component/SettingsComponent.java (+40 -0)
📝 smssync/src/main/java/org/addhen/smssync/presentation/di/module/AppModule.java (+7 -0)
smssync/src/main/java/org/addhen/smssync/presentation/di/module/SettingsModule.java (+41 -0)
smssync/src/main/java/org/addhen/smssync/presentation/presenter/AddLogPresenter.java (+96 -0)
smssync/src/main/java/org/addhen/smssync/presentation/util/TimeFrequencyUtil.java (+39 -0)
📝 smssync/src/main/java/org/addhen/smssync/presentation/util/Utility.java (+16 -0)
smssync/src/main/java/org/addhen/smssync/presentation/view/log/AddLogView.java (+28 -0)
smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/AboutSettingsActivity.java (+122 -0)
smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/AutomationSettingsActivity.java (+37 -0)
smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/BasePreferenceActivity.java (+167 -0)
smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/GeneralSettingsActivity.java (+167 -0)
📝 smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/MainActivity.java (+16 -6)

...and 42 more files

📄 Description

Move different sections of the settings under headings and provide
a high level screen to access the different sections.
Feels more organized this way as it's easier to go to a particular
settings.

  • Theme the toolbar so its text are light and that of its popup is dark
  • Fix #299 - Enable users to provide names for the device at settings screen
  • Fix #298 - Switch Automation with Settings in Navigation drawer

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/305 **Author:** [@eyedol](https://github.com/eyedol) **Created:** 7/27/2015 **Status:** ✅ Merged **Merged:** 7/27/2015 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `3.0.0` ← **Head:** `288-bug-fix` --- ### 📝 Commits (1) - [`bd62c7b`](https://github.com/ushahidi/SMSSync/commit/bd62c7beaaf5bb38b421e0677319f87d63d32b43) Fix #288 - Organize settings screen ### 📊 Changes **62 files changed** (+1981 additions, -143 deletions) <details> <summary>View changed files</summary> 📝 `build.gradle` (+1 -1) 📝 `dependencies/dependencies.gradle` (+16 -12) 📝 `smssync/build.gradle` (+6 -4) 📝 `smssync/src/internal/java/org/addhen/smssync/presentation/di/component/AppComponent.java` (+3 -1) ➕ `smssync/src/internal/res/xml/preference_headers_legacy.xml` (+55 -0) 📝 `smssync/src/main/AndroidManifest.xml` (+59 -6) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/App.java` (+1 -1) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/Prefs.java` (+155 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/di/component/SettingsComponent.java` (+40 -0) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/di/module/AppModule.java` (+7 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/di/module/SettingsModule.java` (+41 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/presenter/AddLogPresenter.java` (+96 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/util/TimeFrequencyUtil.java` (+39 -0) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/util/Utility.java` (+16 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/view/log/AddLogView.java` (+28 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/AboutSettingsActivity.java` (+122 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/AutomationSettingsActivity.java` (+37 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/BasePreferenceActivity.java` (+167 -0) ➕ `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/GeneralSettingsActivity.java` (+167 -0) 📝 `smssync/src/main/java/org/addhen/smssync/presentation/view/ui/activity/MainActivity.java` (+16 -6) _...and 42 more files_ </details> ### 📄 Description Move different sections of the settings under headings and provide a high level screen to access the different sections. Feels more organized this way as it's easier to go to a particular settings. - Theme the toolbar so its text are light and that of its popup is dark - Fix #299 - Enable users to provide names for the device at settings screen - Fix #298 - Switch Automation with Settings in Navigation drawer --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-28 01:24:34 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/SMSSync#427
No description provided.