[PR #212] [MERGED] Better logging in SmsSentReceiver #403

New issue

Closed

opened 2026-02-28 01:24:29 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/212
Author: @vorburger
Created: 10/20/2014
Status: ✅ Merged
Merged: 10/21/2014
Merged by: @eyedol

Base: develop ← Head: SomeMinorLoggingImprovementsInCaseSendingFails

📝 Commits (4)

0bad984 Clear log just in case sendTo is not a global phone phone number
7558c53 Just refactored copy/pasted code to make SmsSentReceiver easier to read (no real changes, yet)
1f32dbc Fixed SmsSentReceiver to fully log even the default failure case (so this does more than just make the code look more readable - note how before this fix, default: did NOT toastLong nor logActivities)
4c9837c Fixed build error, and clarified Q based on @eyedol's code review comment

📊 Changes

3 files changed (+28 additions, -48 deletions)

View changed files

📝 .gitignore (+1 -0)
📝 smssync/src/main/java/org/addhen/smssync/messages/ProcessSms.java (+12 -8)
📝 smssync/src/main/java/org/addhen/smssync/receivers/SmsSentReceiver.java (+15 -40)

📄 Description

No description provided

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/212 **Author:** [@vorburger](https://github.com/vorburger) **Created:** 10/20/2014 **Status:** ✅ Merged **Merged:** 10/21/2014 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `develop` ← **Head:** `SomeMinorLoggingImprovementsInCaseSendingFails` --- ### 📝 Commits (4) - [`0bad984`](https://github.com/ushahidi/SMSSync/commit/0bad9848cc2e3adfa4ebcab33d365a6803d2b976) Clear log just in case sendTo is not a global phone phone number - [`7558c53`](https://github.com/ushahidi/SMSSync/commit/7558c5358769ee756b5e74702e21bbd28d0ab220) Just refactored copy/pasted code to make SmsSentReceiver easier to read (no real changes, yet) - [`1f32dbc`](https://github.com/ushahidi/SMSSync/commit/1f32dbcec980445995758d398df88333e864f47f) Fixed SmsSentReceiver to fully log even the default failure case (so this does more than just make the code look more readable - note how before this fix, default: did NOT toastLong nor logActivities) - [`4c9837c`](https://github.com/ushahidi/SMSSync/commit/4c9837c4e6c6e2f22b4b0de28247dfb67155c7b0) Fixed build error, and clarified Q based on @eyedol's code review comment ### 📊 Changes **3 files changed** (+28 additions, -48 deletions) <details> <summary>View changed files</summary> 📝 `.gitignore` (+1 -0) 📝 `smssync/src/main/java/org/addhen/smssync/messages/ProcessSms.java` (+12 -8) 📝 `smssync/src/main/java/org/addhen/smssync/receivers/SmsSentReceiver.java` (+15 -40) </details> ### 📄 Description _No description provided_ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>