[PR #185] [MERGED] Issue #173 fixed value of sent_to #395

New issue

Closed

opened 2026-02-28 01:24:27 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:27 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/185
Author: @rafalsliwinski
Created: 7/11/2014
Status: ✅ Merged
Merged: 7/23/2014
Merged by: @eyedol

Base: develop ← Head: issue-173_2

📝 Commits (2)

79cd025 Upgrade to build script to use gradle 0.12
0a73a98 Issue #173 value of sent_to is taken from device_id in case of no registered phone number

📊 Changes

10 files changed (+88 additions, -172 deletions)

View changed files

📝 .travis.yml (+13 -4)
📝 build.gradle (+1 -1)
📝 smssync/build.gradle (+2 -2)
➕ smssync/proguard-android.txt (+57 -0)
📝 smssync/src/androidTest/java/org/addhen/smssync/tests/services/SyncSchemeTest.java (+9 -7)
➖ smssync/src/main/java/org/addhen/smssync/fragments/BaseFragment.java (+0 -153)
📝 smssync/src/main/java/org/addhen/smssync/util/Util.java (+1 -1)
📝 smssync/src/main/res/layout/list_log_item.xml (+1 -2)
📝 smssync/src/main/res/values/strings.xml (+3 -1)
📝 website-src/_root/developers.html (+1 -1)

📄 Description

Beside the main fix I changed .travis.yml and some minor things in a couple files like:
-updating string.xml to ignore lack of translation
-making copy of proguard-android.txt from sdk folder in smssync
-updating some tests
-changing baseFragment constructor to have no argument ( I haven't find any usages of this class but if someone want to use it he should take care of passing argument in a different way).

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/185 **Author:** [@rafalsliwinski](https://github.com/rafalsliwinski) **Created:** 7/11/2014 **Status:** ✅ Merged **Merged:** 7/23/2014 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `develop` ← **Head:** `issue-173_2` --- ### 📝 Commits (2) - [`79cd025`](https://github.com/ushahidi/SMSSync/commit/79cd02583681fc4fde58186229c5e65a26657dad) Upgrade to build script to use gradle 0.12 - [`0a73a98`](https://github.com/ushahidi/SMSSync/commit/0a73a987b8c1019f10daebcc69d30698913f6fb0) Issue #173 value of sent_to is taken from device_id in case of no registered phone number ### 📊 Changes **10 files changed** (+88 additions, -172 deletions) <details> <summary>View changed files</summary> 📝 `.travis.yml` (+13 -4) 📝 `build.gradle` (+1 -1) 📝 `smssync/build.gradle` (+2 -2) ➕ `smssync/proguard-android.txt` (+57 -0) 📝 `smssync/src/androidTest/java/org/addhen/smssync/tests/services/SyncSchemeTest.java` (+9 -7) ➖ `smssync/src/main/java/org/addhen/smssync/fragments/BaseFragment.java` (+0 -153) 📝 `smssync/src/main/java/org/addhen/smssync/util/Util.java` (+1 -1) 📝 `smssync/src/main/res/layout/list_log_item.xml` (+1 -2) 📝 `smssync/src/main/res/values/strings.xml` (+3 -1) 📝 `website-src/_root/developers.html` (+1 -1) </details> ### 📄 Description Beside the main fix I changed `.travis.yml` and some minor things in a couple files like: -updating `string.xml` to ignore lack of translation -making copy of `proguard-android.txt` from `sdk` folder in `smssync` -updating some tests -changing `baseFragment` constructor to have no argument ( I haven't find any usages of this class but if someone want to use it he should take care of passing argument in a different way). --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>