[PR #108] [MERGED] Required secret fix #366

New issue

Closed

opened 2026-02-28 01:24:20 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:20 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ushahidi/SMSSync/pull/108
Author: @alxndrsn
Created: 7/19/2013
Status: ✅ Merged
Merged: 7/19/2013
Merged by: @eyedol

Base: develop ← Head: required-secret-fix

📝 Commits (1)

92ca680 Removed requirement for empty secret in api response if no secret is set

📊 Changes

1 file changed (+7 additions, -8 deletions)

View changed files

📝 smssync/src/org/addhen/smssync/util/MessageSyncUtil.java (+7 -8)

📄 Description

Removed the requirement to provide "secret" in API responses if no secret is actually required (previously, an empty secret value was required).

Also cleaned up a couple of uses of TextUtils.isEmpty() combined with redundant null checks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ushahidi/SMSSync/pull/108 **Author:** [@alxndrsn](https://github.com/alxndrsn) **Created:** 7/19/2013 **Status:** ✅ Merged **Merged:** 7/19/2013 **Merged by:** [@eyedol](https://github.com/eyedol) **Base:** `develop` ← **Head:** `required-secret-fix` --- ### 📝 Commits (1) - [`92ca680`](https://github.com/ushahidi/SMSSync/commit/92ca6809afa9835446f12aa878b63ea26e3a941e) Removed requirement for empty secret in api response if no secret is set ### 📊 Changes **1 file changed** (+7 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `smssync/src/org/addhen/smssync/util/MessageSyncUtil.java` (+7 -8) </details> ### 📄 Description Removed the requirement to provide "secret" in API responses if no secret is actually required (previously, an empty secret value was required). Also cleaned up a couple of uses of TextUtils.isEmpty() combined with redundant null checks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>