starred/SMSSync

Fork 0

mirror of https://github.com/ushahidi/SMSSync.git synced 2026-04-25 15:55:57 +03:00

[GH-ISSUE #431] WebServiceEntity and SyncUrl seem to be identical #303

New issue

Open

opened 2026-02-28 01:24:03 +03:00 by kerem · 7 comments

kerem commented

2026-02-28 01:24:03 +03:00

Owner

Originally created by @alxndrsn on GitHub (Apr 8, 2016).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/431

There are two classes which look identical: WebServiceEntity and SyncUrl. I suspect one of them is outdated, but they're both used in various different places in the codebase, so it's not clear if that's actually the case.

Originally created by @alxndrsn on GitHub (Apr 8, 2016). Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/431 There are two classes which look identical: [`WebServiceEntity`](https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/domain/entity/WebServiceEntity.java) and [`SyncUrl`](https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/entity/SyncUrl.java). I suspect one of them is outdated, but they're both used in various different places in the codebase, so it's not clear if that's actually the case.

kerem commented

2026-02-28 01:24:04 +03:00

Author

Owner

@eyedol commented on GitHub (Apr 22, 2016):

@alxndrsn This is a technical debt. The database library uses the class name as the table name. I changed the class names when I was refactoring the code base. Later I discovered I had to maintain the old class name, SyncUrl if I don't want to update the db. This will require writing more code. It needs revisiting. Perhaps for now note a comment in SyncUrl why it's name is so?

@eyedol commented on GitHub (Apr 22, 2016): @alxndrsn This is a technical debt. The database library uses the class name as the table name. I changed the class names when I was refactoring the code base. Later I discovered I had to maintain the old class name, `SyncUrl` if I don't want to update the db. This will require writing more code. It needs revisiting. Perhaps for now note a comment in `SyncUrl` why it's name is so?

kerem commented

2026-02-28 01:24:04 +03:00

Author

Owner

@alxndrsn commented on GitHub (Apr 22, 2016):

If SyncUrl has to stay, would it be possible to remove WebServiceEntity?

@alxndrsn commented on GitHub (Apr 22, 2016): If `SyncUrl` has to stay, would it be possible to remove `WebServiceEntity`?

kerem commented

2026-02-28 01:24:04 +03:00

Author

Owner

@eyedol commented on GitHub (Apr 22, 2016):

We can do that but it'll change the nomenclature all together. You can go for it though.

@eyedol commented on GitHub (Apr 22, 2016): We can do that but it'll change the nomenclature all together. You can go for it though.

kerem commented

2026-02-28 01:24:04 +03:00

Author

Owner

@alxndrsn commented on GitHub (Apr 22, 2016):

Looks like we could change the database table name in BaseDatabaseHelper.onUpgrade(), and therefore get rid of SyncUrl.

@alxndrsn commented on GitHub (Apr 22, 2016): Looks like we could change the database table name in [`BaseDatabaseHelper.onUpgrade()`](https://github.com/ushahidi/SMSSync/blob/a1f2224bbb4488a9772eb35a1d8648e0dc350a59/smssync/src/main/java/org/addhen/smssync/data/database/BaseDatabaseHelper.java#L96), and therefore get rid of `SyncUrl`.

kerem commented

2026-02-28 01:24:04 +03:00

Author

Owner

@eyedol commented on GitHub (Apr 22, 2016):

@alxndrsn Yeah you can. You've to do the data migration. There is no decent migration tool for Android as far as I know. Mostly I write them manually. Say if you upgrade from the app from x.x.y to x.x.z, all the saved data has to move with it. Not sure if there is a sql query to rename a table without having to create temp tables and move data around.

@eyedol commented on GitHub (Apr 22, 2016): @alxndrsn Yeah you can. You've to do the data migration. There is no decent migration tool for Android as far as I know. Mostly I write them manually. Say if you upgrade from the app from x.x.y to x.x.z, all the saved data has to move with it. Not sure if there is a `sql` query to rename a table without having to create temp tables and move data around.

kerem commented

2026-02-28 01:24:04 +03:00

Author

Owner

@alxndrsn commented on GitHub (Apr 22, 2016):

Something like:

ALTER TABLE SyncUrl RENAME TO WebSericeEntity

should do it: https://www.sqlite.org/lang_altertable.html

@alxndrsn commented on GitHub (Apr 22, 2016): Something like: ``` SQL ALTER TABLE SyncUrl RENAME TO WebSericeEntity ``` should do it: https://www.sqlite.org/lang_altertable.html

kerem commented

2026-02-28 01:24:04 +03:00

Author

Owner

@eyedol commented on GitHub (Apr 23, 2016):

That should probably do the trick

@eyedol commented on GitHub (Apr 23, 2016): That should probably do the trick