[GH-ISSUE #419] Message Result list processed for every sync URL #295

New issue

Open

opened 2026-02-28 01:24:02 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:24:02 +03:00

Owner

Originally created by @alxndrsn on GitHub (Apr 7, 2016).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/419

In ProcessMessageResult.processMessageResult(), every message referenced in the MessagesUUIDSResponse will be fetched from the database for every sync URL. It would be more efficient to build the messageResults list once, and then re-use it in each call to sendMessageResultPOSTRequest(syncUrl, messageResults).

Originally created by @alxndrsn on GitHub (Apr 7, 2016). Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/419 In [`ProcessMessageResult.processMessageResult()`](https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java#L90), every message referenced in the `MessagesUUIDSResponse` will be fetched from the database _for every sync URL_. It would be more efficient to build the `messageResults` list once, and then re-use it in each call to [`sendMessageResultPOSTRequest(syncUrl, messageResults)`](https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessageResult.java#L109).