[GH-ISSUE #416] Failed deliveries are not retried if Blacklists are enabled #292

New issue

Open

opened 2026-02-28 01:24:01 +03:00 by kerem · 1 comment

kerem commented

2026-02-28 01:24:01 +03:00

Owner

Originally created by @alxndrsn on GitHub (Apr 7, 2016).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/416

At https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java#L142, messages which fail to post successfully are passed to ProcessMessage.savePendingMessage():

 if (mPrefsFactory.enableBlacklist().get()) {
     ...
 } else {
     if (postMessage(message, syncUrl)) {
         postToSentBox(message);
         deleteFromSmsInbox(message);
     } else {
         savePendingMessage(message);
     }
 }

However, this method will only actually save a pending message if the blacklist option is disabled:

        if (!mPrefsFactory.enableBlacklist().get()) {
            message.setStatus(Message.Status.FAILED);
            mMessageDataSource.putMessage(message);
        }

– https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessage.java#L181

Originally created by @alxndrsn on GitHub (Apr 7, 2016). Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/416 At https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java#L142, messages which fail to post successfully are passed to `ProcessMessage.savePendingMessage()`: ``` if (mPrefsFactory.enableBlacklist().get()) { ... } else { if (postMessage(message, syncUrl)) { postToSentBox(message); deleteFromSmsInbox(message); } else { savePendingMessage(message); } } ``` However, this method will only actually save a pending message if the blacklist option is disabled: ``` if (!mPrefsFactory.enableBlacklist().get()) { message.setStatus(Message.Status.FAILED); mMessageDataSource.putMessage(message); } ``` – _https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/message/ProcessMessage.java#L181_

kerem commented

2026-02-28 01:24:02 +03:00

Author

Owner

@alxndrsn commented on GitHub (Apr 7, 2016):

@alxndrsn commented on GitHub (Apr 7, 2016): Similar code in https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java