[GH-ISSUE #400] Re-using intents in SmsReceiverService #284

New issue

Closed

opened 2026-02-28 01:23:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:23:59 +03:00

Owner

Originally created by @alxndrsn on GitHub (Apr 6, 2016).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/400

In the SmsReceiverService, the AUTO_SYNC_ACTION intent is re-used.

Behaviour when re-using an Intent does not seem to be well defined in the Android docs, so it would likely be safer to create a new Intent each time one is required. There may also be thread-safety issues with the current implementation.

Originally created by @alxndrsn on GitHub (Apr 6, 2016). Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/400 In the `SmsReceiverService`, the [`AUTO_SYNC_ACTION` intent is re-used](https://github.com/ushahidi/SMSSync/blob/master/smssync/src/main/java/org/addhen/smssync/presentation/service/SmsReceiverService.java#L205). Behaviour when re-using an `Intent` does not seem to be well defined in the Android docs, so it would likely be safer to create a new `Intent` each time one is required. There may also be thread-safety issues with the current implementation.