[GH-ISSUE #384] syncPendingMessages() methods do not need arguments #274

New issue

Open

opened 2026-02-28 01:23:58 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 01:23:58 +03:00

Owner

Originally created by @alxndrsn on GitHub (Apr 6, 2016).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/384

There are two very similar methods called syncPendingMessages():

These methods are only called from AutoSyncScheduledService, and the argument is always an empty string. The arguments could be removed, which would simplify the methods.

Originally created by @alxndrsn on GitHub (Apr 6, 2016). Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/384 There are two very similar methods called `syncPendingMessages()`: 1. [`PostMessage.syncPendingMessages(String)`](https://github.com/ushahidi/SMSSync/blob/a1f2224bbb4488a9772eb35a1d8648e0dc350a59/smssync/src/main/java/org/addhen/smssync/data/message/PostMessage.java#L164) 2. [`TweetMessage.syncPendingMessages(String)`](https://github.com/ushahidi/SMSSync/blob/a1f2224bbb4488a9772eb35a1d8648e0dc350a59/smssync/src/main/java/org/addhen/smssync/data/message/TweetMessage.java#L144) These methods are only called from [`AutoSyncScheduledService`](https://github.com/ushahidi/SMSSync/blob/a1f2224bbb4488a9772eb35a1d8648e0dc350a59/smssync/src/main/java/org/addhen/smssync/presentation/service/AutoSyncScheduledService.java#L58), and the argument is always an empty string. The arguments could be removed, which would simplify the methods.