mirror of
https://github.com/ushahidi/SMSSync.git
synced 2026-04-26 00:05:57 +03:00
[GH-ISSUE #173] sent_to payload keyword always present and empty #132
Labels
No labels
Bug report
Code improvement
Concern
Feature request
Feature request
Good first issue to work on
In progress
Needs info
Question
Ready
Translation
User Experience
User Experience
Website
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SMSSync#132
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @redbullpeter on GitHub (May 31, 2014).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/173
Independent of whether I include sent_to as a payload keyword in the Sync URL configuration, the server side script always shows sent_to as parameter and with no value. When I do a print_r($_REQUEST, true) the PHP script shows that sent_to is being passed as a parameter and is blank. Adding or removing sent_to as a payload keyword has no effect.
Phone details are:
Make: Sony Ericsson
Model: LT15i
Android Ver: 2.3.4
Make: Micromax
Model: A27
Android Ver: 2.3.5
@devlogy commented on GitHub (May 31, 2014):
Hello,
I confirm this issue.
Regards,
Cesar
@redbullpeter commented on GitHub (Jun 22, 2014):
The issue still exists on v2.6
@rafalsliwinski commented on GitHub (Jul 8, 2014):
Hello,
I looked into this issue and I found what was the problem. Function getLine1Number() from class TelephonyManager which is used for it don't work if your phone number is not register in your mobile. Only solution I can think of is to add option to set or change this number in settings. @eyedol What do you think about it?
@eyedol commented on GitHub (Jul 9, 2014):
@rafalsliwinski yes
getLine1Number()only gets the phone number if it's registered on the SIM card. That could work but we need to verify the number the user enters. Like send a code as SMS ? Lot of work I think.I'm thinking we drop support for
sent_toasunique_idwhich is manually set on the phone can be used to serve the same purposesent_towas serving.@eyedol commented on GitHub (Jul 9, 2014):
Let's just replace the value returned by
getLine1Numberwith theunique_idvalue ifgetLine1NumberreturnsNULLor empty string. Over time we will depreciate thesent_tovariable. And document this change inwebsite-src. Specifically under developers page.