mirror of
https://github.com/ushahidi/SMSSync.git
synced 2026-04-25 15:55:57 +03:00
[GH-ISSUE #148] Secret key for AES encryption #115
Labels
No labels
Bug report
Code improvement
Concern
Feature request
Feature request
Good first issue to work on
In progress
Needs info
Question
Ready
Translation
User Experience
User Experience
Website
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SMSSync#115
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @9px on GitHub (Apr 1, 2014).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/148
using of valid HTTPS is not free, and using of HTTP is insecure.
also SECRET key can be listening by an attacker over HTTP.
it is desirable to use SECRET-key as key for encrypt exchanged data with method such as AES.
if this feature request approved, you can add an option to disable this as default for compatibility with older version PHP code.
@eyedol commented on GitHub (Apr 17, 2015):
@9px asking for more clarification. You saying we should replace the use of
secretwithSECRET-keyas the request variable?@9px commented on GitHub (Apr 17, 2015):
@eyedol first; thanks for your attention.
no. i suggest an option to adding in SMSSync setting:
AES secret keyif user set the option, data exchange with server will be encrypt by the
AES secret keyinstead of current plain data exchange.naturally; for URL-safe data exchange, encrypted data must be encoded by base64.
@rjmackay commented on GitHub (Apr 20, 2015):
@9px Am I right that you're asking for us to encrypt the secret key when in transit between SMSSync and the server?
I'm not really sure we have the expertise / bandwidth to build something like that.. unless theres some existing encrypted auth scheme and libs we could rely on..
Aside: there are a number of free SSL cert providers now.
@9px commented on GitHub (Apr 20, 2015):
@rjmackay no. i say: instead of send/get sms text to/from server in simple plain text, send/get it with an encryption method. (such as AES).

this is very safe against sniffing HTTP trafic or MITM attack in HTTPS.
@redbullpeter commented on GitHub (Apr 20, 2015):
Some crypto info here: https://www.owasp.org/index.php/Java_Security_Frameworks
You could use this library: https://github.com/google/keyczar on the client end. To keep it simple, you could for example fix the encyption algorithm and use only a symmetric key system. The complexity starts on how to decrypt on the server end as that's not something you will have control over. Depending on the server environment the necessary libraries may not be installed.
@9px commented on GitHub (Apr 20, 2015):
thanks @redbullpeter. in server side usualy available encrypt/decrypt function/module for each language. for example in PHP we have some built-in function to do this, also in python, nodejs, etc.