starred/SMSSync

Fork 0

mirror of https://github.com/ushahidi/SMSSync.git synced 2026-04-25 07:45:53 +03:00

[GH-ISSUE #15] SMS center #11

New issue

Open

opened 2026-02-28 01:22:44 +03:00 by kerem · 9 comments

kerem commented

2026-02-28 01:22:44 +03:00

Owner

Originally created by @helmers on GitHub (Feb 19, 2012).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/15

Would it be possible for you to add when the URL get called, to also include SMS center.

Originally created by @helmers on GitHub (Feb 19, 2012). Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/15 Hi Would it be possible for you to add when the URL get called, to also include SMS center.

kerem added the

Feature request

Good first issue to work on

labels

2026-02-28 01:22:44 +03:00

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@eyedol commented on GitHub (Feb 20, 2012):

Hi @helmers,

Why would you want that? Also, what exactly do you mean by include SMS center

@eyedol commented on GitHub (Feb 20, 2012): Hi @helmers, Why would you want that? Also, what exactly do you mean by include SMS center

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@olliebennett commented on GitHub (Feb 24, 2013):

I believe @helmers is suggesting that as an extra parameter in the POST to the server, the app could include the SMS Center address.

I believe it's possible, through use of android.telephony.SmsMessage.getServiceCenterAddress().

As for possible uses of this, I've not investigated, but perhaps it could be somehow used for basic geo-location functionality? I believe a change in the message center address/number/id/whatever suggests the phone has moved from one region, and into the range of another message center...

@olliebennett commented on GitHub (Feb 24, 2013): I believe @helmers is suggesting that as an extra parameter in the POST to the server, the app could include the [SMS Center](http://en.wikipedia.org/wiki/Short_message_service_center) address. I believe it's possible, through use of [`android.telephony.SmsMessage.getServiceCenterAddress()`](http://developer.android.com/reference/android/telephony/SmsMessage.html#getServiceCenterAddress%28%29). As for possible uses of this, I've not investigated, but _perhaps_ it could be somehow used for basic geo-location functionality? I believe a change in the message center address/number/id/whatever suggests the phone has moved from one region, and into the range of another message center...

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@2kodes commented on GitHub (Aug 7, 2014):

hi,
is this issue still open? Getting the sms center might help in situations where one might want to verify the authenticity of the message being received on the server side. Yes the security token or secret can be used but an additional feature such as the sms center will be helpful especially as i think it cannot be faked easily. Where in the code or file may this functionality be added? Unfortunately I am not that good at java else i would have submitted a patch for this. Any pointers will be much appreciated

@2kodes commented on GitHub (Aug 7, 2014): hi, is this issue still open? Getting the sms center might help in situations where one might want to verify the authenticity of the message being received on the server side. Yes the security token or secret can be used but an additional feature such as the sms center will be helpful especially as i think it cannot be faked easily. Where in the code or file may this functionality be added? Unfortunately I am not that good at java else i would have submitted a patch for this. Any pointers will be much appreciated

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@olliebennett commented on GitHub (Aug 7, 2014):

Hi @2kodes

While I have no strong argument for not implementing this feature, I do think it would be mis-guided to rely on it as a means of authentication / security. When you say it "cannot be faked easily", all it would take is for a user to modify the app to hard-code the value, and re-build it to install on their device. Therefore, no app-controlled mechanism like this can be truly secure.

There are a couple of locations you will need to update. The best way to find these is probably to search for something like sent_timestamp or message_id (or other variables which are published in the message to the server).

A few places to start:

Add sms_centre to pretty much every method in SyncScheme
Populate your sms_centre value in MessageSyncHttpClient's initRequest() method.

I believe you would need to call the getServiceCenterAddress() method that I linked above.

@olliebennett commented on GitHub (Aug 7, 2014): Hi @2kodes While I have no strong argument for not implementing this feature, I do think it would be mis-guided to rely on it as a means of authentication / security. When you say it "cannot be faked easily", all it would take is for a user to modify the app to hard-code the value, and re-build it to install on their device. Therefore, no app-controlled mechanism like this can be truly secure. There are a couple of locations you will need to update. The best way to find these is probably to search for something like `sent_timestamp` or `message_id` (or other variables which are published in the message to the server). A few places to start: - Add `sms_centre` to pretty much every method in [SyncScheme](https://github.com/ushahidi/SMSSync/blob/develop/smssync/src/main/java/org/addhen/smssync/net/SyncScheme.java) - Populate your `sms_centre` value in [MessageSyncHttpClient](https://github.com/ushahidi/SMSSync/blob/develop/smssync/src/main/java/org/addhen/smssync/net/MessageSyncHttpClient.java)'s `initRequest()` method. I believe you would need to call the `getServiceCenterAddress()` method that I linked above.

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@2kodes commented on GitHub (Aug 7, 2014):

@olliebennett
Thanks for the info. will get on it asap.

@2kodes commented on GitHub (Aug 7, 2014): @olliebennett Thanks for the info. will get on it asap.

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@eyedol commented on GitHub (Apr 17, 2015):

@2kodes any updates?

@eyedol commented on GitHub (Apr 17, 2015): @2kodes any updates?

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@sizons commented on GitHub (Apr 21, 2015):

Doesn't look like much being asked for. I'm going to also give it a try.

@sizons commented on GitHub (Apr 21, 2015): Doesn't look like much being asked for. I'm going to also give it a try.

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@eyedol commented on GitHub (Apr 21, 2015):

@sizons feel free to go for it. Let me know if you need clarification or any help in getting this implemented.

@eyedol commented on GitHub (Apr 21, 2015): @sizons feel free to go for it. Let me know if you need clarification or any help in getting this implemented.

kerem commented

2026-02-28 01:22:45 +03:00

Author

Owner

@sizons commented on GitHub (Apr 21, 2015):

I will thanks. Let me dive in.

@sizons commented on GitHub (Apr 21, 2015): I will thanks. Let me dive in.

kerem referenced this issue

2026-02-28 01:22:59 +03:00

[GH-ISSUE #70] Only allow sending to phone's current country #63

kerem referenced this issue

2026-02-28 01:23:18 +03:00