mirror of
https://github.com/ushahidi/SMSSync.git
synced 2026-04-25 15:55:57 +03:00
[GH-ISSUE #128] Make Google Analytics an opt-out option at build time #102
Labels
No labels
Bug report
Code improvement
Concern
Feature request
Feature request
Good first issue to work on
In progress
Needs info
Question
Ready
Translation
User Experience
User Experience
Website
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/SMSSync#102
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @mvdan on GitHub (Oct 3, 2013).
Original GitHub issue: https://github.com/ushahidi/SMSSync/issues/128
It would be nice to have Google Analytics be optional at build time with gradle, using something like a noAnalytics flavour. Without it, we cannot build nor update your app on F-Droid, since it now requires non-free software (after #116).
I can provide a build.gradle patch if you want me to.
Regards.
@eyedol commented on GitHub (Oct 3, 2013):
@mvdan send the patch over
@mvdan commented on GitHub (Oct 8, 2013):
@eyedol I thought it would be as simple as undoing some of your commits to the java files, but it isn't. Though here is a good example by @ligi:
https://github.com/ligi/gobandroid/tree/master/android/src/noAnalytics/java/org/ligi/gobandroid_hd/ui
He set up build.gradle with flavours and groups as follows:
https://github.com/ligi/gobandroid/blob/master/android/build.gradle
@eyedol commented on GitHub (Oct 9, 2013):
@mvdan thanks for the links. I'll look into this over the weekend. Keep you posted.
@eyedol commented on GitHub (Nov 11, 2013):
@mvdan long overdue but it's here. See
9b89290a10Want to give it a try?