starred/QueryString

Fork 0

mirror of https://github.com/ersinkoc/QueryString.git synced 2026-04-26 22:46:00 +03:00

[PR #2] [MERGED] Comprehensive repository bug analysis and fix #3

New issue

Closed

opened 2026-03-04 14:45:26 +03:00 by kerem · 0 comments

kerem commented

2026-03-04 14:45:26 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/ersinkoc/QueryString/pull/2
Author: @ersinkoc
Created: 11/8/2025
Status: ✅ Merged
Merged: 11/8/2025
Merged by: @ersinkoc

Base: main ← Head: claude/comprehensive-repo-bug-analysis-011CUvKRARha1f13ZGqqvmg7

📝 Commits (1)

8aa9463 fix: resolve all 53 ESLint violations - comprehensive type safety improvements

📊 Changes

14 files changed (+495 additions, -619 deletions)

View changed files

📝 BUG_ANALYSIS_REPORT.md (+317 -366)
📝 BUG_FIX_SUMMARY.md (+81 -189)
📝 src/builder.ts (+1 -1)
📝 src/index.ts (+17 -17)
📝 src/parser.ts (+6 -6)
📝 src/plugins.ts (+29 -21)
📝 src/schema.ts (+15 -0)
📝 src/security.ts (+7 -4)
📝 src/stringifier.ts (+8 -8)
📝 src/types/index.ts (+7 -1)
📝 src/types/schema.ts (+1 -0)
📝 src/utils/array.ts (+4 -4)
📝 src/utils/encoding.ts (+1 -1)
📝 src/utils/object.ts (+1 -1)

📄 Description

…rovements

Fixed all ESLint errors across the codebase while maintaining 100% test pass rate and 99.33%+ code coverage. All changes are backward compatible with no breaking API changes.

Bug Fixes (53 total):

Type Safety (47 fixes):
- Added missing return type annotations (6 files)
- Replaced 'any' types with proper types (40 occurrences)
- Replaced generic Function type with specific signatures (1 fix)
Code Quality (6 fixes):
- Fixed unnecessary regex escapes (2 files)
- Removed unused variables in plugins (4 occurrences)

Files Modified:

src/parser.ts: Fixed type safety with null handling and removed any types
src/stringifier.ts: Added return types to encoder callbacks
src/builder.ts: Added return type to unless() callback
src/plugins.ts: Typed globalThis usage, cleaner iteration, removed any types
src/schema.ts: Documented legitimate any usage with eslint-disable
src/index.ts: Added return types to wrapper functions, improved type safety
src/security.ts: Replaced Function type with specific signature
src/types/*.ts: Properly typed generic helpers
src/utils/*.ts: Replaced any with Primitive types, fixed regex

Testing:

All 495 tests passing ✓
Coverage: 99.33% statements, 95.54% branches, 92.24% functions, 99.48% lines ✓
ESLint: 0 errors (was 53) ✓

Breaking Changes: None
API Changes: None (internal type improvements only)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/ersinkoc/QueryString/pull/2 **Author:** [@ersinkoc](https://github.com/ersinkoc) **Created:** 11/8/2025 **Status:** ✅ Merged **Merged:** 11/8/2025 **Merged by:** [@ersinkoc](https://github.com/ersinkoc) **Base:** `main` ← **Head:** `claude/comprehensive-repo-bug-analysis-011CUvKRARha1f13ZGqqvmg7` --- ### 📝 Commits (1) - [`8aa9463`](https://github.com/ersinkoc/QueryString/commit/8aa94638b719dc58ed2d5ab3456dc5880eaab8ea) fix: resolve all 53 ESLint violations - comprehensive type safety improvements ### 📊 Changes **14 files changed** (+495 additions, -619 deletions) <details> <summary>View changed files</summary> 📝 `BUG_ANALYSIS_REPORT.md` (+317 -366) 📝 `BUG_FIX_SUMMARY.md` (+81 -189) 📝 `src/builder.ts` (+1 -1) 📝 `src/index.ts` (+17 -17) 📝 `src/parser.ts` (+6 -6) 📝 `src/plugins.ts` (+29 -21) 📝 `src/schema.ts` (+15 -0) 📝 `src/security.ts` (+7 -4) 📝 `src/stringifier.ts` (+8 -8) 📝 `src/types/index.ts` (+7 -1) 📝 `src/types/schema.ts` (+1 -0) 📝 `src/utils/array.ts` (+4 -4) 📝 `src/utils/encoding.ts` (+1 -1) 📝 `src/utils/object.ts` (+1 -1) </details> ### 📄 Description …rovements Fixed all ESLint errors across the codebase while maintaining 100% test pass rate and 99.33%+ code coverage. All changes are backward compatible with no breaking API changes. Bug Fixes (53 total): - Type Safety (47 fixes): * Added missing return type annotations (6 files) * Replaced 'any' types with proper types (40 occurrences) * Replaced generic Function type with specific signatures (1 fix) - Code Quality (6 fixes): * Fixed unnecessary regex escapes (2 files) * Removed unused variables in plugins (4 occurrences) Files Modified: - src/parser.ts: Fixed type safety with null handling and removed any types - src/stringifier.ts: Added return types to encoder callbacks - src/builder.ts: Added return type to unless() callback - src/plugins.ts: Typed globalThis usage, cleaner iteration, removed any types - src/schema.ts: Documented legitimate any usage with eslint-disable - src/index.ts: Added return types to wrapper functions, improved type safety - src/security.ts: Replaced Function type with specific signature - src/types/*.ts: Properly typed generic helpers - src/utils/*.ts: Replaced any with Primitive types, fixed regex Testing: - All 495 tests passing ✓ - Coverage: 99.33% statements, 95.54% branches, 92.24% functions, 99.48% lines ✓ - ESLint: 0 errors (was 53) ✓ Breaking Changes: None API Changes: None (internal type improvements only) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-03-04 14:45:26 +03:00

closed this issue
added the
pull-request
label

No labels

pull-request

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/QueryString#3

No description provided.

Rows
Columns