[PR #139] [MERGED] Separated the command handlers #998

New issue

Closed

opened 2026-02-27 15:52:44 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/139
Author: @yankejustin
Created: 5/16/2015
Status: ✅ Merged
Merged: 5/16/2015
Merged by: @MaxXor

Base: master ← Head: SeparateCommandHandlers

📝 Commits (2)

ac93887 Separated the CommandHandler
4bda01a Separated the CommandHandler

📊 Changes

13 files changed (+1614 additions, -1502 deletions)

View changed files

📝 Client/Client.csproj (+5 -0)
📝 Client/Core/Commands/CommandHandler.cs (+3 -929)
➕ Client/Core/Commands/ConnectionHandler.cs (+98 -0)
➕ Client/Core/Commands/FileHandler.cs (+244 -0)
➕ Client/Core/Commands/MiscHandler.cs (+224 -0)
➕ Client/Core/Commands/SurveillanceHandler.cs (+135 -0)
➕ Client/Core/Commands/SystemHandler.cs (+287 -0)
📝 Server/Core/Commands/CommandHandler.cs (+3 -573)
➕ Server/Core/Commands/ConnectionHandler.cs (+94 -0)
➕ Server/Core/Commands/MiscHandler.cs (+131 -0)
➕ Server/Core/Commands/SurveillanceHandler.cs (+197 -0)
➕ Server/Core/Commands/SystemHandler.cs (+189 -0)
📝 Server/Server.csproj (+4 -0)

📄 Description

What this changes:

These changes do not modify or change the function of the code.
These changes merely improve the code so it is easier to use, read, and change.

Reason:

I realized that, eventually, I was reading and constantly having to waste time scrolling through long classes of the server and client's CommandHandler.cs
These two classes were each ~1,000 lines. I reasoned that these should be separated. Just to help us programmers out so we don't have to constantly spend time scrolling and scrolling. As a bonus, logic is separated.

Will this affect the code output?:

No. The resulting code is not affected. Because these different Command Handler files are partial classes, that means that when it is compiled, these files will be treated as if they are together.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/139 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 5/16/2015 **Status:** ✅ Merged **Merged:** 5/16/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `SeparateCommandHandlers` --- ### 📝 Commits (2) - [`ac93887`](https://github.com/quasar/Quasar/commit/ac93887af356d0ea0371a1741ba4634ad852b7f3) Separated the CommandHandler - [`4bda01a`](https://github.com/quasar/Quasar/commit/4bda01a98ce1241d23b9f70166193c9e272fd3e4) Separated the CommandHandler ### 📊 Changes **13 files changed** (+1614 additions, -1502 deletions) <details> <summary>View changed files</summary> 📝 `Client/Client.csproj` (+5 -0) 📝 `Client/Core/Commands/CommandHandler.cs` (+3 -929) ➕ `Client/Core/Commands/ConnectionHandler.cs` (+98 -0) ➕ `Client/Core/Commands/FileHandler.cs` (+244 -0) ➕ `Client/Core/Commands/MiscHandler.cs` (+224 -0) ➕ `Client/Core/Commands/SurveillanceHandler.cs` (+135 -0) ➕ `Client/Core/Commands/SystemHandler.cs` (+287 -0) 📝 `Server/Core/Commands/CommandHandler.cs` (+3 -573) ➕ `Server/Core/Commands/ConnectionHandler.cs` (+94 -0) ➕ `Server/Core/Commands/MiscHandler.cs` (+131 -0) ➕ `Server/Core/Commands/SurveillanceHandler.cs` (+197 -0) ➕ `Server/Core/Commands/SystemHandler.cs` (+189 -0) 📝 `Server/Server.csproj` (+4 -0) </details> ### 📄 Description <h1><b>What this changes</b>:</h1> <b>These changes do not modify or change the function of the code.</b> These changes merely <i>improve</i> the code so it is easier to use, read, and change. <h1><b>Reason</b>:</h1> I realized that, eventually, I was reading and <b>constantly</b> having to waste time scrolling through <i>long</i> classes of the server and client's CommandHandler.cs These two classes were each ~1,000 lines. I reasoned that these should be separated. Just to help us programmers out so we don't have to constantly spend time scrolling and scrolling. As a bonus, logic is separated. <h1><b>Will this affect the code output?</b>:</h1> <b>No.</b> The resulting code is <b><i>not</i></b> affected. Because these different Command Handler files are <i>partial</i> classes, that means that when it is compiled, these files will be treated as if they are together. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>