[PR #59] [MERGED] Some improved behavior changes #964

New issue

Closed

opened 2026-02-27 15:52:38 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:38 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/59
Author: @yankejustin
Created: 4/13/2015
Status: ✅ Merged
Merged: 4/14/2015
Merged by: @MaxXor

Base: master ← Head: master

📝 Commits (3)

0624500 Terms of Use Form closes in a better way
40b2b8d Rewrote a method and improved behavior
6af33c5 Merge pull request #1 from MaxXor/master

📊 Changes

3 files changed (+33 additions, -24 deletions)

View changed files

📝 Server/Forms/FrmFileManager.cs (+9 -12)
📝 Server/Forms/FrmSettings.cs (+22 -10)
📝 Server/Forms/FrmTermsOfUse.cs (+2 -2)

📄 Description

Terms of Use Form closes in a different way.
... By killing a process using Process.Kill(), the process is terminated forcefully and does not allow finally-blocks or finalizers to be executed. This is not a desirable effect and can potentially cause difficult-to-find bugs. Should use Application.Exit() in its place.
Rewrote a method and improved another
... The Listen method now uses try-finally blocks so that the state of the Settings Form doesn't get stuck if a Socket Exception occurs.
... Rewrote a method in the File Manager Form that performs the same decisions, but is much simpler, requires less strings to be created, and doesn't need to make the same decision twice without reason.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/59 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 4/13/2015 **Status:** ✅ Merged **Merged:** 4/14/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (3) - [`0624500`](https://github.com/quasar/Quasar/commit/0624500555da023c6deafafd8aa17426d40ff293) Terms of Use Form closes in a better way - [`40b2b8d`](https://github.com/quasar/Quasar/commit/40b2b8db5bf1d63df9d4b2ff4859ba6ba7808060) Rewrote a method and improved behavior - [`6af33c5`](https://github.com/quasar/Quasar/commit/6af33c5d5a47e65e77af59ef5a5c0d40b5b2182b) Merge pull request #1 from MaxXor/master ### 📊 Changes **3 files changed** (+33 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `Server/Forms/FrmFileManager.cs` (+9 -12) 📝 `Server/Forms/FrmSettings.cs` (+22 -10) 📝 `Server/Forms/FrmTermsOfUse.cs` (+2 -2) </details> ### 📄 Description 1) Terms of Use Form closes in a different way. ... By killing a process using Process.Kill(), the process is terminated forcefully and does not allow finally-blocks or finalizers to be executed. This is not a desirable effect and can potentially cause difficult-to-find bugs. Should use Application.Exit() in its place. 2) Rewrote a method and improved another ... The Listen method now uses try-finally blocks so that the state of the Settings Form doesn't get stuck if a Socket Exception occurs. ... Rewrote a method in the File Manager Form that performs the same decisions, but is much simpler, requires less strings to be created, and doesn't need to make the same decision twice without reason. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>