[PR #48] [MERGED] Code Consistency and Clarity, Performance, and a Small Fix #960

New issue

Closed

opened 2026-02-27 15:52:37 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 15:52:37 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/quasar/Quasar/pull/48
Author: @yankejustin
Created: 4/8/2015
Status: ✅ Merged
Merged: 4/8/2015
Merged by: @MaxXor

Base: master ← Head: master

📝 Commits (5)

b927aae Make sure to dispose of old Socket
8ecd568 Fixed the loop that attempts to forward a port
295daca Some code consistency improvements
d5cb5b9 Performance and clean-up for both SafeQuickLZ
e720d20 Compacted Builder method

📊 Changes

7 files changed (+126 additions, -115 deletions)

View changed files

📝 Client/Core/Compression/SafeQuickLZ.cs (+23 -20)
📝 Client/Core/Helper/FileSplit.cs (+7 -8)
📝 Server/Core/Compression/SafeQuickLZ.cs (+23 -20)
📝 Server/Core/Helper/FileSplit.cs (+7 -8)
📝 Server/Core/Helper/UPnP.cs (+9 -5)
📝 Server/Core/Server.cs (+10 -0)
📝 Server/Forms/FrmBuilder.cs (+47 -54)

📄 Description

Fixed a rather small memory leak with the Server Socket potentially not being disposed of correctly, fixed a loop in the Server's 'UPnP' class that only gave one chance for a valid end-point to be found, improved the consistency in some parts of the code, optimized both of the 'SafeQuickLZ' class's Compression method, and compacted the Builder Form's 'Build' method to improve speed and to reduce redundancy .

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/quasar/Quasar/pull/48 **Author:** [@yankejustin](https://github.com/yankejustin) **Created:** 4/8/2015 **Status:** ✅ Merged **Merged:** 4/8/2015 **Merged by:** [@MaxXor](https://github.com/MaxXor) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (5) - [`b927aae`](https://github.com/quasar/Quasar/commit/b927aae0f869e81293a1fd05edcb039ee9a458c3) Make sure to dispose of old Socket - [`8ecd568`](https://github.com/quasar/Quasar/commit/8ecd568acf3d9c8549a63e89c556ab25f8e47963) Fixed the loop that attempts to forward a port - [`295daca`](https://github.com/quasar/Quasar/commit/295daca123e7f8991a877964f37d4a58c30544fc) Some code consistency improvements - [`d5cb5b9`](https://github.com/quasar/Quasar/commit/d5cb5b9c92f716d801b3025f8d02e238ea094236) Performance and clean-up for both SafeQuickLZ - [`e720d20`](https://github.com/quasar/Quasar/commit/e720d208111318666ac4be57445eed6ec67a4692) Compacted Builder method ### 📊 Changes **7 files changed** (+126 additions, -115 deletions) <details> <summary>View changed files</summary> 📝 `Client/Core/Compression/SafeQuickLZ.cs` (+23 -20) 📝 `Client/Core/Helper/FileSplit.cs` (+7 -8) 📝 `Server/Core/Compression/SafeQuickLZ.cs` (+23 -20) 📝 `Server/Core/Helper/FileSplit.cs` (+7 -8) 📝 `Server/Core/Helper/UPnP.cs` (+9 -5) 📝 `Server/Core/Server.cs` (+10 -0) 📝 `Server/Forms/FrmBuilder.cs` (+47 -54) </details> ### 📄 Description Fixed a rather small memory leak with the Server Socket potentially not being disposed of correctly, fixed a loop in the Server's 'UPnP' class that only gave one chance for a valid end-point to be found, improved the consistency in some parts of the code, optimized both of the 'SafeQuickLZ' class's Compression method, and compacted the Builder Form's 'Build' method to improve speed and to reduce redundancy . --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>